Page MenuHomeFreeBSD

linsysfs(4): Refactor to avoid referencing an unstable interfaces
ClosedPublic

Authored by dchagin on Feb 26 2023, 9:44 AM.
Referenced Files
Unknown Object (File)
Mon, Dec 1, 3:44 PM
Unknown Object (File)
Sat, Nov 29, 11:29 AM
Unknown Object (File)
Sat, Nov 29, 8:06 AM
Unknown Object (File)
Fri, Nov 28, 12:34 AM
Unknown Object (File)
Thu, Nov 27, 7:57 PM
Unknown Object (File)
Wed, Nov 26, 7:01 PM
Unknown Object (File)
Tue, Nov 25, 1:48 AM
Unknown Object (File)
Thu, Nov 20, 10:04 PM
Subscribers

Details

Summary

Enter the net epoch when traversing a list of interfaces. For that
split the ifname_linux_to_bsd() function on two counterparts, where
the ifname_linux_to_ifp() intended to use in epoch, while the
ifname_linux_to_bsd() intended to be a self-contained.
Until the linux_ioctl_coket() function is refactored, the
ifname_linux_to_bsd() temporarily returns interface outside
of the epoch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro added inline comments.
sys/compat/linsysfs/linsysfs.c
127

Maybe the other way round? In that case, you don't need to have an additional epoch exit.

128

Nit: IIRC sbuf_printf() cannot sleep, so it's worth writing ifindex inside the epoch and avoid using a temporary variable.

146

Nit: same as previous one: do everything inside ifp != NULL condition

This revision is now accepted and ready to land.Feb 27 2023, 11:24 AM

done, btw, you are right, sbuf here don't sleep,
also vnet context stored as V_ifnet is not iniitalized without it

This revision now requires review to proceed.Mar 2 2023, 9:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2023, 9:13 AM
This revision was automatically updated to reflect the committed changes.