[NEW PORT] editors/sam: Add the sam text editor

[flo_purplekraken.com]

Summary

This is an updated version of the Unix port of the sam text editor from Bell Labs.

Test Plan

• portlint: OK
• portclippy: OK
• poudriere testport: OK

[arrowd]

editors/sam/files/patch-doc_Makefile

11

Why replace symlinks with copies?

[flo_purplekraken.com]

editors/sam/files/patch-doc_Makefile

11

Because otherwise, make stage-qa complains about symlinks into the staging area:

====> Running Q/A tests (stage-qa)
Error: Bad symlink 'share/man/man1/samterm.1.gz' pointing inside the stage directory
Error: Bad symlink 'share/man/man1/sam.save.1.gz' pointing inside the stage directory
Error: Bad symlink 'share/man/man1/B.1.gz' pointing inside the stage directory
Error: Bad symlink 'share/man/man1/rsam.1.gz' pointing inside the stage directory
*** Error code 1

[arrowd]

editors/sam/files/patch-doc_Makefile

11

Since all these man pages are in the same directory, just make the link relative:

ln -sf "sam.1" "$(MANDIR)/man1/B.1"

[diizzy]

editors/sam/Makefile

23

You probabaly want USES= localbase:ldflags instead?

editors/sam/files/patch-doc_Makefile

11

Since we seem to patch quite a lot perhaps its worth considering not executing "make install" at all and use ${RLN) etc in do-install section?

[flo_purplekraken.com]

editors/sam/Makefile

23

I did not know about it, a big improvement. Thanks.

editors/sam/files/patch-doc_Makefile

11

I updated the diff, but I'm not sure about the ${RLN} usage.

[diizzy]

editors/sam/Makefile

31

Having a quick look it seems like you can reduce do-install to:

${INSTALL_PROGRAM} ${WRKSRC}/sam/sam ${STAGEDIR}${PREFIX}/bin
${RLN} ${STAGEDIR}${PREFIX}/bin/sam ${STAGEDIR}${PREFIX}/bin/B
${INSTALL_PROGRAM} ${WRKSRC}/samterm/samterm ${STAGEDIR}${PREFIX}/bin
${INSTALL_SCRIPT} ${WRKSRC}/ssam/ssam.sh ${STAGEDIR}${PREFIX}/bin/ssam
${INSTALL_MAN} ${WRKSRC}/doc/sam.1 ${STAGEDIR}${PREFIX}/share/man/man1
${RLN} ${STAGEDIR}${PREFIX}/share/man/man1/sam.1 ${STAGEDIR}${PREFIX}/share/man/man1/B.1
${RLN} ${STAGEDIR}${PREFIX}/share/man/man1/sam.1 ${STAGEDIR}${PREFIX}/share/man/man1/samterm.1
${RLN} ${STAGEDIR}${PREFIX}/share/man/man1/sam.1 ${STAGEDIR}${PREFIX}/share/man/man1/rsam.1
${RLN} ${STAGEDIR}${PREFIX}/share/man/man1/sam.1 ${STAGEDIR}${PREFIX}/share/man/man1/sam.save.1
${INSTALL_MAN} ${WRKSRC}/doc/samrc.5 ${STAGEDIR}${PREFIX}/share/man/man5

[diizzy]

editors/sam/Makefile

24

-I${LOCALBASE}/include/freetype2 seems to work fine? :-)

[flo_purplekraken.com]

editors/sam/Makefile

24

Well, this habit is a result of working with too many bad libraries professionally ;)
I'll change it to -I.

31

I missed that the libraries are static only, thanks for the hint!

[flo_purplekraken.com]

Incorporate the feedback from Daniel, which brings much improvement.

[arrowd]

editors/sam/Makefile

28

No need for < redirection here.

[flo_purplekraken.com]

Removed file redirection into sed

[arrowd]

editors/sam/Makefile

13

Sort these uses.

20

Sort these values.

24

You don't seem to depend on freetype2.

[flo_purplekraken.com]

editors/sam/Makefile

20

Are these not already sorted?

[arrowd]

editors/sam/Makefile

20

Yes, sorry.

[flo_purplekraken.com]

Add missing dependency on print/freetype2

[flo_purplekraken.com]

editors/sam/Makefile

24

The dependency was actually missing, thanks for catching it!

[arrowd]

Pushed in, thanks!