devel/gdb: Remove the EXPAT option.

[jhb]

Summary

GDB on FreeBSD requires libxml for full funtionality (e.g. 'catch
syscall <syscall name>' parses the XML files installed in
LOCALBASE/share that were still installed even when this option was
disabled). Also, using GDB with a debug server that returns any
non-simple registers requires XML support for parsing the target
description returned by the server (e.g. examining SSE or later
registers or any system registers when attached to QEMU or
lldb-server).

[emaste]

LGTM

[danfe]

devel/gdb/Makefile

31

Are these two needed? I recall it was autodetected properly once installed. We typically don't reinforce (reiterate) options which match default behavior.

37

Please add the entry to existing LIB_DEPENDS above (keeping it properly sorted) rathen than amending it in the middle of the Makefile.

[jhb]

Add review feedback from danfe@.

[jhb]

Rebase

[danfe]

Thanks for fixing the libraries' order in LIB_DEPENDS John, this is good to go now.