sysutils/debootstrap: Fix several issues

[zirias]

Summary

• PORTVERSION may not contain '-', use 'n' instead to include the nmu-number from debian. (Pointy-hat: zirias)
• Don't use substitutions on Makefile, pass variables instead
• Eliminate "static" substitutions, use a patch-file instead
• Fix hardcoded /usr/local in debootstrap script

PR: 269584

[zirias]

Also remove substitutions that are now no-ops.

[zirias]

And also make portclippy happy, as it's almost for free here

[zirias]

Rebase after committing the PORTVERSION fix separately

[zirias]

Fix more hardcoded /usr/local after comment in PR 269584

[rfyu28uyeg_snkmail.com]

Updates look good to me. I like '#!/usr/bin/env bash' better (see comments in bug 269584, but I understand the tendency of the project toward hard-coded shebangs in most cases.

sysutils/debootstrap/Makefile

35–37

Lots of extra REINPLACE_CMD calls here. Less efficient and it triggers warnings if DEVELOPER=yes.

See also Bug 269584, comment 18 & comment 22.

[rfyu28uyeg_snkmail.com]

sysutils/debootstrap/Makefile

43

See also bug 255525 suggesting pcre[2]grep instead of gnu grep. If nothing else pcregrep is a BSD license and probably maintained a little better than gnu grep. One less gnu dependency is good. And it's probably somewhat more likely someone has devel/pcre{,2} installed than ggrep due to more dependencies on pcre than gnugrep.

Could also use 'ggrep' instead of full path with LOCALBASE/bin.

[zirias]

sysutils/debootstrap/Makefile

35–37

It's the same number of invocations as in your suggestion....

43

Here as well, I'm not a fan of fixing things that aren't broken. Plus, upstream is Debian, expecting GNU tools, so I'd consider using GNU grep here more robust regarding possible future changes.

[rfyu28uyeg_snkmail.com]

sysutils/debootstrap/Makefile

43

Agreed - valid point.

[nc]

I think it looks good, feel free to commit.