Page MenuHomeFreeBSD
Differential D38694

security/openssh-portable: Fix build on i386
Needs ReviewPublic
Actions

Authored by zirias on Feb 20 2023, 1:30 PM.
Tags
None
Referenced Files
F174949034: D38694.id117627.diff
Wed, Oct 7, 3:41 AM
Unknown Object (File)
Sun, Oct 4, 2:07 PM
Unknown Object (File)
Thu, Oct 1, 7:55 AM
Unknown Object (File)
Wed, Sep 30, 11:07 PM
Unknown Object (File)
Sun, Sep 20, 10:18 PM
Unknown Object (File)
Sat, Sep 12, 2:48 PM
Unknown Object (File)
Thu, Sep 10, 1:47 AM
Unknown Object (File)
Wed, Sep 9, 4:44 PM
View All Files
Subscribers
mat

Details

Reviewers
bdrewery
tcberner

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49913
Build 46805: arc lint + arc unit

Event Timeline

zirias created this revision.Feb 20 2023, 1:30 PM
Herald added a subscriber: mat. · View Herald TranscriptFeb 20 2023, 1:30 PM
zirias requested review of this revision.Feb 20 2023, 1:30 PM
Harbormaster completed remote builds in B49913: Diff 117627.Feb 20 2023, 1:30 PM
mat added a comment.Feb 22 2023, 10:15 AM

Does this really have to be an extra patch? Does it break the build on other archs?

zirias added a comment.Feb 24 2023, 11:21 AM
In D38694#881222, @mat wrote:

Does this really have to be an extra patch? Does it break the build on other archs?

Most likely no. I just wanted to avoid introducing explicit casts where not necessary. Although I'm pretty sure they have no effect on the code on 64bit platforms....

Revision Contents
Changeset List

PathSize
security/
openssh-portable/
4 lines
files/
18 lines

Diff 117627

View Options

security/openssh-portable/Makefile

Loading...
View Options

security/openssh-portable/files/extra-patch-time_t-sign-compare

Loading...