Page MenuHomeFreeBSD
Differential D38694

security/openssh-portable: Fix build on i386
Needs ReviewPublic
Actions

Authored by zirias on Feb 20 2023, 1:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 28, 6:20 AM
Unknown Object (File)
Mon, Apr 27, 11:51 PM
Unknown Object (File)
Mon, Apr 27, 3:40 PM
Unknown Object (File)
Fri, Apr 24, 2:02 PM
Unknown Object (File)
Tue, Apr 21, 9:31 AM
Unknown Object (File)
Mon, Apr 20, 9:32 PM
Unknown Object (File)
Mon, Apr 20, 4:08 AM
Unknown Object (File)
Sun, Apr 19, 8:12 PM
View All 80 Files
Subscribers
mat

Details

Reviewers
bdrewery
tcberner

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49913
Build 46805: arc lint + arc unit

Event Timeline

zirias created this revision.Feb 20 2023, 1:30 PM
Herald added a subscriber: mat. · View Herald TranscriptFeb 20 2023, 1:30 PM
zirias requested review of this revision.Feb 20 2023, 1:30 PM
Harbormaster completed remote builds in B49913: Diff 117627.Feb 20 2023, 1:30 PM
mat added a comment.Feb 22 2023, 10:15 AM

Does this really have to be an extra patch? Does it break the build on other archs?

zirias added a comment.Feb 24 2023, 11:21 AM
In D38694#881222, @mat wrote:

Does this really have to be an extra patch? Does it break the build on other archs?

Most likely no. I just wanted to avoid introducing explicit casts where not necessary. Although I'm pretty sure they have no effect on the code on 64bit platforms....

Revision Contents
Changeset List

PathSize
security/
openssh-portable/
4 lines
files/
18 lines

Diff 117627

View Options

security/openssh-portable/Makefile

Loading...
View Options

security/openssh-portable/files/extra-patch-time_t-sign-compare

Loading...