Page MenuHomeFreeBSD

sysutils/lxqt-config: Fix build after new plasma
ClosedPublic

Authored by zirias on Feb 20 2023, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 3:59 PM
Unknown Object (File)
Mon, Dec 2, 3:54 PM
Unknown Object (File)
Sun, Dec 1, 4:31 PM
Unknown Object (File)
Fri, Nov 29, 5:42 PM
Unknown Object (File)
Fri, Nov 29, 12:06 AM
Unknown Object (File)
Mon, Nov 25, 8:03 AM
Unknown Object (File)
Mon, Nov 25, 8:03 AM
Unknown Object (File)
Mon, Nov 25, 8:03 AM
Subscribers

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for looking into this! Looks good but you could perhaps use upstream with PATCH_SITES and PATCHFILE since they (also ) did the changes https://github.com/lxqt/lxqt-config/commit/6add4e4f0040693e7c4242fbae48c9d3200768.patch ? Just an opinion, I use to do that with non released upstream changes, it makes it easier for me to know which patches are belonging to upstream, and expected in next release..

Thanks I already used that myself. Unfortunately, there's no common agreement this is a good idea. But if you ask me, I prefer adding upstream patches that way!
The only reason this isn't committed yet is my test-build (for smoke-testing the change) is still running :-)

Updated to fetch necessary patch directly from upstream, test builds fine.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2023, 10:18 PM
This revision was automatically updated to reflect the committed changes.