Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 49917 Build 46809: arc lint + arc unit
Event Timeline
Thanks for looking into this! Looks good but you could perhaps use upstream with PATCH_SITES and PATCHFILE since they (also ) did the changes https://github.com/lxqt/lxqt-config/commit/6add4e4f0040693e7c4242fbae48c9d3200768.patch ? Just an opinion, I use to do that with non released upstream changes, it makes it easier for me to know which patches are belonging to upstream, and expected in next release..
Example of jsm's suggestion, https://cgit.freebsd.org/ports/commit/irc/irssi/Makefile?id=bc97cc7b70dea8f491605a7670932805dcb9ea97
Thanks I already used that myself. Unfortunately, there's no common agreement this is a good idea. But if you ask me, I prefer adding upstream patches that way!
The only reason this isn't committed yet is my test-build (for smoke-testing the change) is still running :-)