Page MenuHomeFreeBSD

Change "ctlstat -P"'s schema
ClosedPublic

Authored by asomers on Feb 11 2023, 12:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 3:24 AM
Unknown Object (File)
Dec 12 2023, 1:01 PM
Unknown Object (File)
Nov 5 2023, 2:54 PM
Unknown Object (File)
Oct 4 2023, 1:52 PM
Unknown Object (File)
Sep 24 2023, 6:58 AM
Unknown Object (File)
Sep 24 2023, 6:58 AM
Unknown Object (File)
Sep 24 2023, 6:57 AM
Unknown Object (File)
Sep 5 2023, 11:48 AM
Subscribers

Details

Summary

Change "ctlstat -P"'s schema

It now reports stats separately for both ports and luns.

Also, prohibit using both "-p" and "-P" at the same time.

Test Plan

Manually tested with Prometheus and Grafana

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

We previously discussed publishing a join table to associate targets with luns. But I realized that I actually don't need that for our purposes, so I didn't implement it.

Makes sense on a brief look.

This revision is now accepted and ready to land.Feb 13 2023, 12:19 AM
This revision was automatically updated to reflect the committed changes.