Makefile.amd64: remove construct that serves no purpose
ClosedPublic
Actions

Authored by kan on Feb 8 2023, 3:02 PM.

Details

Reviewers

Commits

rG89a072d11cd2: Makefile.amd64: remove construct that serves no purpose

Summary

The variable expansion as written will never match anything but
'amd64/.8' in OBJDIR. The original intention behind the construct
remains unclear, but "as is" it serves no other purpose but to
generate the warning. Remove it altogether.

Test Plan

Any 'make' invocation in usr.sbin is not nicely silent.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kan requested review of this revision.Feb 8 2023, 3:02 PM

kan created this revision.

Harbormaster completed remote builds in B49624: Diff 116787.Feb 8 2023, 3:02 PM

Go for it. I have this code in my tree too and it's good, but might not solve all the weird issues we see in build output now... but it's clearly completely bogus for this context. There's no man pages here, nothing to see.
If you don't do this for a day or two, I will... but I have some other, more pressing issues to attend to first.

This revision is now accepted and ready to land.Feb 8 2023, 3:39 PM

Closed by commit rG89a072d11cd2: Makefile.amd64: remove construct that serves no purpose (authored by kan, committed by imp). · Explain WhyFeb 8 2023, 7:22 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG89a072d11cd2: Makefile.amd64: remove construct that serves no purpose.