Sponsored by: Klara, Inc.
- Group Reviewers
- rGd8c9f8089187: libc: Update mktime(3) / timegm(3) tests.
Presumably we shouldn't rely on errno being clear if the call was successful? Where does it get set?
We should probably stop clearing errno above too then?
Neither C nor POSIX say anything about mktime() setting errno. It just so happens that a previous version of tzcode left errno untouched when mktime() was successful, NetBSD incorrectly assumed that this was mandated and added a test for it, and we trusted them and imported that test. The current version of tzcode almost always sets errno to EOVERFLOW on 64-bit platforms, even when successful, so the test fails.
This is contrib code, I don't want to make gratuitous changes.