Page MenuHomeFreeBSD
Differential D38172

w: Complete libxo transition.
ClosedPublic
Actions

Authored by des on Jan 23 2023, 4:24 PM.
Tags
None
Referenced Files
F132557199: D38172.id.diff
Fri, Oct 17, 11:10 PM
F132488797: D38172.id115708.diff
Fri, Oct 17, 8:33 AM
F132484098: D38172.id.diff
Fri, Oct 17, 7:36 AM
Unknown Object (File)
Tue, Oct 14, 8:33 PM
Unknown Object (File)
Tue, Oct 14, 4:26 PM
Unknown Object (File)
Sun, Oct 12, 4:13 AM
Unknown Object (File)
Sat, Oct 11, 6:09 PM
Unknown Object (File)
Sat, Oct 11, 6:09 PM
View All Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rGa6edc5b39209: w: Complete libxo transition.
rGd90ff31ae5cd: w: Complete libxo transition.
Summary

MFC after: 1 week
Sponsred by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Jan 23 2023, 4:24 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 23 2023, 4:24 PM
des requested review of this revision.Jan 23 2023, 4:24 PM
Harbormaster completed remote builds in B49197: Diff 115452.Jan 23 2023, 4:24 PM
markj added a subscriber: markj.Jan 23 2023, 7:36 PM
markj added inline comments.
usr.bin/w/w.c
475–476

It looks like xo_finish() returns a number of bytes written, so shouldn't we be checking for a result < 0?

des updated this revision to Diff 115510.Jan 24 2023, 8:49 AM

Fix xo_finish() check

Harbormaster completed remote builds in B49204: Diff 115510.Jan 24 2023, 8:49 AM
des marked an inline comment as done.Jan 24 2023, 8:49 AM
des added inline comments.
usr.bin/w/w.c
475–476

You are absolutely right.

markj accepted this revision as: markj.Jan 24 2023, 2:06 PM
This revision is now accepted and ready to land.Jan 24 2023, 2:06 PM
Closed by commit rGd90ff31ae5cd: w: Complete libxo transition. (authored by des). · Explain WhyJan 25 2023, 6:23 AM
This revision was automatically updated to reflect the committed changes.
des marked an inline comment as done.
des added a commit: rGd90ff31ae5cd: w: Complete libxo transition..
des added a commit: rGa6edc5b39209: w: Complete libxo transition..Feb 9 2023, 8:41 PM

Revision Contents
Changeset List

PathSize
usr.bin/
w/
17 lines

Diff 115708

View Options

usr.bin/w/w.c

Loading...