Page MenuHomeFreeBSD
Differential D38135

hms: fix copy/paste issue
ClosedPublic
Actions

Authored by yuri_aetern.org on Jan 20 2023, 11:01 AM.
Tags
None
Referenced Files
F132469373: D38135.id.diff
Fri, Oct 17, 4:54 AM
Unknown Object (File)
Tue, Oct 14, 10:58 AM
Unknown Object (File)
Tue, Oct 14, 10:58 AM
Unknown Object (File)
Tue, Oct 14, 10:58 AM
Unknown Object (File)
Mon, Oct 13, 8:43 PM
Unknown Object (File)
Sat, Sep 27, 10:02 PM
Unknown Object (File)
Sep 2 2025, 1:45 PM
Unknown Object (File)
Sep 1 2025, 1:52 AM
View All 72 Files
Subscribers
imp

Details

Reviewers
wulf
Commits
rG6f7b5d5d3c2e: hms(4): Fix a copy/paste issue and check both _X and _Y
Summary

Fix what seems to be a copy/paste issue and check both _X and _Y instead of checking _X 2 times.

Test Plan

Build.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuri_aetern.org created this revision.Jan 20 2023, 11:01 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 20 2023, 11:01 AM
yuri_aetern.org requested review of this revision.Jan 20 2023, 11:01 AM
wulf accepted this revision.Jan 20 2023, 7:18 PM

LGTM

Thanks! What string I should place in to commit's "Author" git tag?

This revision is now accepted and ready to land.Jan 20 2023, 7:18 PM
yuri_aetern.org added a comment.Jan 20 2023, 8:15 PM
In D38135#866420, @wulf wrote:

LGTM

Thanks! What string I should place in to commit's "Author" git tag?

"Yuri <yuri@aetern.org>" should do.

Closed by commit rG6f7b5d5d3c2e: hms(4): Fix a copy/paste issue and check both _X and _Y (authored by yuri_aetern.org, committed by wulf). · Explain WhyJan 20 2023, 8:32 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rG6f7b5d5d3c2e: hms(4): Fix a copy/paste issue and check both _X and _Y.
wulf added a comment.Jan 20 2023, 8:37 PM

Committed. Thank you!

Revision Contents
Changeset List

PathSize
sys/
dev/
hid/
2 lines

Diff 115371

View Options

sys/dev/hid/hms.c

Loading...