databases/akonadi: Build all backends, but don't runtime-depend on them.

[arrowd]

Test Plan

poudriere testport

[arrowd]

• Restore OPTIONS.
• Make Sqlite default.

[arrowd]

[fluffy]

Ship it!

[tcberner]

I am think this is fine. But it likely could need some documentation in UPDATING,

As it might break mail for people that are using mysql for the alonadi storage.

So that makes me a bit fearful of the change.

[makc]

As far as I remember akonadi devs were strongly against using sqlite back in kde4 days. mysql_embedded was a compromise between akonadi requirements and users experience. I doubt anything has changed since then.

[arrowd]

Make note in UPDATING and pkg-message

[arrowd]

As it might break mail for people that are using mysql for the alonadi storage.
So that makes me a bit fearful of the change.

Yes, but we now have a warning in UPDATING, a warning in pkg-message on upgrade and also Akonadi saves last used backend in its configuration file. This means that it won't silently switch to sqlite, but will give a error to the user.

As far as I remember akonadi devs were strongly against using sqlite back in kde4 days. mysql_embedded was a compromise between akonadi requirements and users experience. I doubt anything has changed since then.

True, but there are also scenarios when Akonadi isn't actually used, but gets pulled in by pkg install kde5 or even pkg install plasma5-plasma. If the user doesn't plan to use Akonadi at all, there is no need in pulling MySQL server.

[makc]

In D38095#867928, @arrowd wrote:

As far as I remember akonadi devs were strongly against using sqlite back in kde4 days. mysql_embedded was a compromise between akonadi requirements and users experience. I doubt anything has changed since then.

True, but there are also scenarios when Akonadi isn't actually used, but gets pulled in by pkg install kde5 or even pkg install plasma5-plasma. If the user doesn't plan to use Akonadi at all, there is no need in pulling MySQL server.

I have not idea how many users use Akonadi, users are not aware whether they use Akonadi or not. They just run KMail or Akregator and expect it to work. In FreeBSD we already have a problem with KDirWatch (see bugs/258974 for example), which makes user experience with KDE less pleasant, switching to sqlite definitely won't make it better. If novice FreeBSD user installs KDE Plasma and a bit later has to figure out how to reconfigure Akonadi with mysql — this is not nice from our side. Is mysql-server really a big problem? How much do we gain if we switch to sqlite and how much do we lose?

Set defaults to ease new users to setup their systems. Once they are got experienced they could use options to customize it to their needs.

UPDATING

17 ↗

(On Diff #115718)

Not, it is not sufficient, the corresponding version of mysql-server is also required. Users don't need to configure sql server themselves, akonadi does the work for them.

[arrowd]

• Brind back runtime deps.
• Enable sqlite backend unconditionally.

[arrowd]

All right then, let's keep these changes minimal.

The port still defaults to MySQL, I only removed SQLITE option and enabled it unconditionally. This at least allows switching backends without recompiling.

[arrowd]

Bump. This is now non-invasive change, please review.

[tcberner]

databases/akonadi/Makefile

50–51

^ looking at the CMakeLists.txt, it looks like that will only set the default backend?
And it is not well defined what will happen to be the default when both options of the port are toggled on, I think. (Not sure that there is a good solution for this).

[arrowd]

databases/akonadi/Makefile

50–51

^ looking at the CMakeLists.txt, it looks like that will only set the default backend?

That's correct.

And it is not well defined what will happen to be the default when both options of the port are toggled on

Not at all. When both options are selected only the first .if will be evaluated - the second one is inside .else (which can be converted to .elif, BTW!).

So, this follows upstream in preferring MySQL in all cases, except when only PostgreSQL is selected.

[arrowd]

• Convert .else + .if into .elif.

[tcberner]

I think as this keeps the status quo with having mysql as the default it is save to go in.

[dev_submerge.ch]

Hm, are you guys aware that this commit removes the default dependency on MySQL when no specific options are set?
That means users of akonadi in its standard setup will now render their existing installations unusable by a package upgrade.
I was lucky to catch this when doing pkg autoremove, but not everybody knows about that.

[arrowd]

Oops, that wasn't intended. I will fix it ASAP, sorry for this.