Page MenuHomeFreeBSD
Differential D38074

textproc/fcitx5-gtk*: Add GTK4 support
ClosedPublic
Actions

Authored by lwhsu on Jan 16 2023, 7:53 AM.
Tags
None
Referenced Files
F160957773: D38074.id.diff
Mon, Jun 29, 10:16 AM
Unknown Object (File)
Sun, Jun 28, 11:12 AM
Unknown Object (File)
Fri, Jun 26, 2:01 AM
Unknown Object (File)
Tue, Jun 23, 7:28 AM
Unknown Object (File)
Sun, Jun 21, 8:56 PM
Unknown Object (File)
Thu, Jun 18, 1:37 PM
Unknown Object (File)
Thu, Jun 18, 1:37 PM
Unknown Object (File)
Mon, Jun 15, 9:15 PM
View All Files
Subscribers
diizzy
mat

Details

Reviewers
khng
Commits
R11:5d6891c1e621: textproc/fcitx5-gtk*: Add GTK4 support
Summary
  • Split into gtk2, gtk3, gtk4 FLAVORS
  • Extract common files to textproc/fcitx5-gtk-common

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lwhsu created this revision.Jan 16 2023, 7:53 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 16 2023, 7:53 AM
lwhsu requested review of this revision.Jan 16 2023, 7:53 AM
Harbormaster completed remote builds in B49130: Diff 115176.Jan 16 2023, 7:53 AM
diizzy added a subscriber: diizzy.Jan 16 2023, 10:05 AM

Is it worth keeping GTK2 around? It's EOL and we want to remove it at some point... (some point being years ago)

lwhsu added a comment.Jan 16 2023, 5:57 PM
In D38074#865004, @diizzy wrote:

Is it worth keeping GTK2 around? It's EOL and we want to remove it at some point... (some point being years ago)

This patch is aiming for adding new feature and I don't want to break current working things. Let's remove it along with other gtk2 stuff.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2023, 1:13 PM
Closed by commit R11:5d6891c1e621: textproc/fcitx5-gtk*: Add GTK4 support (authored by lwhsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: R11:5d6891c1e621: textproc/fcitx5-gtk*: Add GTK4 support.

Revision Contents
Changeset List

PathSize
textproc/
1 line
fcitx5-gtk-common/
18 lines
fcitx5-gtk/
28 lines
6 lines
3 lines
3 lines
1 line

Diff 119045

View Options

textproc/Makefile

Loading...
View Options

textproc/fcitx5-gtk-common/Makefile

Loading...
View Options

textproc/fcitx5-gtk/Makefile

Loading...
View Options

textproc/fcitx5-gtk/pkg-plist

Loading...
View Options

textproc/fcitx5-gtk/pkg-plist.common

Loading...
View Options

textproc/fcitx5-gtk/pkg-plist.gtk2

Loading...
View Options

textproc/fcitx5-gtk/pkg-plist.gtk3

Loading...
View Options

textproc/fcitx5-gtk/pkg-plist.gtk4

Loading...