Page MenuHomeFreeBSD

mixer: Fix default_unit switching with mixers that have no devices
ClosedPublic

Authored by markj on Jan 15 2023, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 6:12 AM
Unknown Object (File)
Mar 12 2024, 9:44 AM
Unknown Object (File)
Mar 12 2024, 9:44 AM
Unknown Object (File)
Mar 12 2024, 9:44 AM
Unknown Object (File)
Mar 8 2024, 5:33 AM
Unknown Object (File)
Jan 12 2024, 8:12 AM
Unknown Object (File)
Jan 5 2024, 2:45 AM
Unknown Object (File)
Jan 5 2024, 2:42 AM
Subscribers

Details

Summary

Apparently it's possible for a mixer to have no devices:

$ mixer -f /dev/mixer2
pcm2:mixer: <USB audio> at ? kld snd_uaudio (rec)

If this is the default sound device, an attempt to change the default
unit using mixer -d fails with a segfault because mod_dunit is called
with a NULL device pointer, which is dereferenced to get the parent
mixer.

ctl_dunit seems to be a dummy, i.e., we don't actually need it and can
simply pass the mixer to mod_dunit() directly. This patch removes that
structure and associated indirection to fix the crash.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable