Page MenuHomeFreeBSD

mixer: Fix default_unit switching with mixers that have no devices
ClosedPublic

Authored by markj on Jan 15 2023, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 8:33 AM
Unknown Object (File)
Mon, Oct 13, 12:41 PM
Unknown Object (File)
Mon, Oct 13, 12:07 AM
Unknown Object (File)
Mon, Oct 13, 12:07 AM
Unknown Object (File)
Mon, Oct 13, 12:07 AM
Unknown Object (File)
Sun, Oct 12, 12:36 PM
Unknown Object (File)
Thu, Oct 9, 9:34 PM
Unknown Object (File)
Tue, Sep 30, 11:25 AM
Subscribers

Details

Summary

Apparently it's possible for a mixer to have no devices:

$ mixer -f /dev/mixer2
pcm2:mixer: <USB audio> at ? kld snd_uaudio (rec)

If this is the default sound device, an attempt to change the default
unit using mixer -d fails with a segfault because mod_dunit is called
with a NULL device pointer, which is dereferenced to get the parent
mixer.

ctl_dunit seems to be a dummy, i.e., we don't actually need it and can
simply pass the mixer to mod_dunit() directly. This patch removes that
structure and associated indirection to fix the crash.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable