Page MenuHomeFreeBSD

mixer: Fix default_unit switching with mixers that have no devices
ClosedPublic

Authored by markj on Jan 15 2023, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 5, 4:06 AM
Unknown Object (File)
Mon, Oct 5, 3:19 AM
Unknown Object (File)
Mon, Oct 5, 1:31 AM
Unknown Object (File)
Thu, Oct 1, 9:42 AM
Unknown Object (File)
Wed, Sep 23, 8:40 PM
Unknown Object (File)
Wed, Sep 23, 7:52 PM
Unknown Object (File)
Wed, Sep 23, 4:44 PM
Unknown Object (File)
Fri, Sep 11, 4:29 AM
Subscribers

Details

Summary

Apparently it's possible for a mixer to have no devices:

$ mixer -f /dev/mixer2
pcm2:mixer: <USB audio> at ? kld snd_uaudio (rec)

If this is the default sound device, an attempt to change the default
unit using mixer -d fails with a segfault because mod_dunit is called
with a NULL device pointer, which is dereferenced to get the parent
mixer.

ctl_dunit seems to be a dummy, i.e., we don't actually need it and can
simply pass the mixer to mod_dunit() directly. This patch removes that
structure and associated indirection to fix the crash.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable