Page MenuHomeFreeBSD

www/hedgedoc: NEW PORT web-hosted markdown doc editor
AbandonedPublic

Authored by dch on Jan 15 2023, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 7, 12:34 PM
Unknown Object (File)
Fri, Jun 7, 12:20 AM
Unknown Object (File)
Fri, May 31, 5:29 PM
Unknown Object (File)
Sat, May 18, 9:46 AM
Unknown Object (File)
May 17 2024, 3:07 AM
Unknown Object (File)
May 17 2024, 3:07 AM
Unknown Object (File)
May 17 2024, 3:06 AM
Unknown Object (File)
May 17 2024, 3:06 AM

Details

Test Plan

poudriere OK on arm64 & amd64 13.1-RELEASE + CURRENT

  • needs a decent pkg-message explaining usage
  • and some real-world functional testing

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49163
Build 46052: arc lint + arc unit

Event Timeline

dch requested review of this revision.Jan 15 2023, 12:26 AM

some questions and recommendations

www/hedgedoc/Makefile
13
59

what does this do?

103

can you briefly explain what all the things are that we're grooving here?

www/hedgedoc/files/hedgedoc.in
27

I don't know if this is the best idea
people might wanna run this thing behind a reverse proxy which might also use the same user

i think a dedicated user would be better

44

indentation seems off here

This revision now requires changes to proceed.Jan 15 2023, 9:38 AM
dch marked 2 inline comments as done.Jan 15 2023, 3:57 PM
dch added inline comments.
www/hedgedoc/Makefile
13

what do you mean here? I've tested the sqlite variant, should we add other ones as well?

59

this is my ports tree helper, to build the yarn cache tarball, that is eventually stored in LOCAL/dch distfiles.

103

these are all the tmp garbage files created during build of each module, that we don't need to ship.

www/hedgedoc/files/hedgedoc.in
27

I will add *IDs

27

btw there's nothing stopping people adding their own users with this setup. but we have 500+ IDs free, so lets use one.

dch marked 2 inline comments as done.

incorporate recommendations

fix pkg-plist user/group

freebsd_igalic.co added inline comments.
www/hedgedoc/Makefile
13

SQLite is necessary for the b build.
the other databases could be provided as options
but for a first throw this is more than adequate.

the instructions above do tell you what you need to do, but not how

we could add those instructions ourselves

103

it feels like this should be more generalisable, given that we end up with 16 Thousand files in plist, but it's probably a good enough start

This revision now requires changes to proceed.Jan 15 2023, 4:35 PM
www/hedgedoc/pkg-plist
6

are you modifying any config or anything to tell hedgedoc where to find its documentation??

dch marked 5 inline comments as done.

prune pkg-plist a bit

dch marked an inline comment as done.Jan 19 2023, 9:13 AM
dch added inline comments.
www/hedgedoc/Makefile
13

postgresql is available. I think the info in pkg-message is good enough for the moment?

www/hedgedoc/pkg-plist
6

no; AFAICT these are simply the same docs as on the website. I will ask upstream if they have an idea to make them accessible in the hedgedoc web ui.

improve pkg-message a bit