Page MenuHomeFreeBSD

kern/clock: remove interrupt reporting from watchdog_fire()
ClosedPublic

Authored by ehem_freebsd_m5p.com on Dec 24 2022, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 5:03 AM
Unknown Object (File)
Jan 3 2024, 5:21 AM
Unknown Object (File)
Dec 23 2023, 3:04 AM
Unknown Object (File)
Dec 10 2023, 11:08 PM
Unknown Object (File)
Dec 3 2023, 3:36 AM
Unknown Object (File)
Nov 14 2023, 1:22 AM
Unknown Object (File)
Nov 9 2023, 2:24 PM
Unknown Object (File)
Nov 7 2023, 10:59 AM
Subscribers

Details

Summary

The interrupt counts may have been valuable in the past, but now DDB can
readily provide them. Since the full list of counters is expected to
disappear from the global space, remove the reporting from
watchdog_fire().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

@mhorne, you're the one who suggested this at https://reviews.freebsd.org/D36610#858610. Almost seems too small to bother with the review system, but at the same time.

fuz requested changes to this revision.Jan 31 2023, 12:27 AM
fuz added a subscriber: fuz.
fuz added inline comments.
sys/kern/kern_clock.c
830–831

With this change, interrupt information is no longer dumped. Comment should be adapted.

This revision now requires changes to proceed.Jan 31 2023, 12:27 AM
ehem_freebsd_m5p.com marked an inline comment as done.

True enough, edit the comment too.

Looks good on style alone, though I can't say much about functionality. I wonder if intrcnt, intrnames, and friends will still be needed after this change.

This revision is now accepted and ready to land.Jan 31 2023, 10:45 AM
In D37870#869982, @fuz_fuz.su wrote:

Looks good on style alone, though I can't say much about functionality. I wonder if intrcnt, intrnames, and friends will still be needed after this change.

They definitely still are. I aim to get them removed, but I need reviewers/committers.

Thanks, I can get this one committed without any dependencies. I will check out D36610 before the week is over.