Page MenuHomeFreeBSD

framework: add poppler.mk to depend on poppler-ish ports
Needs ReviewPublic

Authored by tcberner on Dec 9 2022, 11:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 6:42 AM
Unknown Object (File)
Thu, Mar 28, 8:27 PM
Unknown Object (File)
Thu, Mar 28, 6:36 AM
Unknown Object (File)
Mar 27 2024, 6:36 AM
Unknown Object (File)
Mar 11 2024, 9:29 AM
Unknown Object (File)
Jan 20 2024, 7:56 PM
Unknown Object (File)
Dec 20 2023, 6:51 AM
Unknown Object (File)
Nov 11 2023, 1:08 PM
Subscribers
None

Details

Reviewers
mat
bapt
Group Reviewers
portmgr
desktop
Summary

Usage: USES=poppler:ARGS
Valid ARGS: <none>,lib,glib,qt5,qt6,utils,utils_build

for usage by the ports tree:
        <none>: default = lib
        lib:            LIB_DEPEND on graphics/poppler
        glib:           LIB_DEPEND on graphics/poppler-glib     implies lib
        qt5:            LIB_DPEEND on graphics/poppler-qt5      implies lib
        qt6:            LIB_DEPEND on graphics/poppler-qt6      implies lib
        utils:          RUN_DEPEND on graphics/poppler-utils
        utils_build:    BUILD_DEPEND on graphics/poppler-utils
for internal use:
        selfbuild:      only used by graphics/poppler to get _POPPLER_VERSION

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48697
Build 45583: arc lint + arc unit

Event Timeline

Mk/Uses/poppler.mk
27–37

I have a feeling it would be easier to make the implies work by just adding the lib to the ones that need the lib.

Mk/Uses/poppler.mk
27–37

do you mean

doing an .if here in the mk instead of the shenanigans on line 44, or do you doing explicit poppler:qt5,lib in the ports Makefiles?

  • poppler.mk: remove IMPLIES feature
  • poppler.mk: update dependencies
  • poppler.mk: fix conversion in math/cantor and print/pdf-tools
Mk/Uses/poppler.mk
27–37

I meant what I proposed in the diff, add ${_POPPLER_lib_LIB_DEPENDS} to the _POPPLER_glib_LIB_DEPENDS, _POPPLER_qt5_LIB_DEPENDS and _POPPLER_qt6_LIB_DEPENDS variables, no need to spam the ports with the implied dependencies.

  • poppler.mk: remove IMPLIES feature
  • poppler.mk: update dependencies
  • poppler.mk: fix conversion in math/cantor and print/pdf-tools
  • Revert "poppler.mk: remove IMPLIES feature"
  • poppler.mk: add implied _lib_ depends via poppler.mk
  • Revert "poppler.mk: update dependencies"
tcberner added inline comments.
Mk/Uses/poppler.mk
27–37

ok, I think now I got it :D

Two typos, and a simplification.

Mk/Uses/poppler.mk
31
34
41–48