Differential D37609

ixl: silence runtime warning when PCI_IOV is not enabled
ClosedPublic
Actions

Authored by gallatin on Dec 5 2022, 10:16 PM.

Details

Reviewers

erj

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rG17859d538c23: ixl: silence runtime warning when PCI_IOV is not enabled

Summary

Even when PCI_IOV is not enabled, ixl still attempts to call iflib_softirq_alloc_generic(...IFLIB_INTR_IOV), which results in warnings similar to the following.

taskqgroup_attach_cpu: qid not found for iov cpu=2
ixl2: taskqgroup_attach_cpu failed 22

#ifdef out this call to iflib_softirq_alloc_generic() so as to silence these warnings.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gallatin created this revision.Dec 5 2022, 10:16 PM

Owners added a reviewer: Restricted Owners Package.Dec 5 2022, 10:16 PM

Herald added subscribers: ae, imp. · View Herald TranscriptDec 5 2022, 10:16 PM

gallatin requested review of this revision.Dec 5 2022, 10:16 PM

Looks good to us.

This revision is now accepted and ready to land.Dec 6 2022, 12:15 AM

Closed by commit rG17859d538c23: ixl: silence runtime warning when PCI_IOV is not enabled (authored by gallatin). · Explain WhyDec 6 2022, 4:39 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rG17859d538c23: ixl: silence runtime warning when PCI_IOV is not enabled.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

if_ixl.c

3 lines

Diff 113880

View Options

ixl: silence runtime warning when PCI_IOV is not enabledClosedPublicActions