Paths

Table of Contentst

kref: replace hand-rolled atomic ops with refcount API
ClosedPublic
Actions

Authored by mjg on Dec 5 2022, 5:41 PM.

Tags

None

Referenced Files

	F166526786: D37608.id113859.diff
	Fri, Aug 14, 1:34 AM

	F166469655: D37608.diff
	Thu, Aug 13, 6:26 PM

	F166468250: D37608.id.diff
	Thu, Aug 13, 6:15 PM

	Unknown Object (File)
	Thu, Aug 13, 4:38 AM

	Unknown Object (File)
	Thu, Aug 13, 12:25 AM

	Unknown Object (File)
	Wed, Aug 12, 7:25 PM

	Unknown Object (File)
	Wed, Aug 12, 8:35 AM

	Unknown Object (File)
	Tue, Aug 11, 11:22 PM

Subscribers

Details

Reviewers

None

Group Reviewers

linuxkpi

Commits

rG67e628b7a643: kref: replace hand-rolled atomic ops with refcount API

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Dec 5 2022, 5:41 PM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptDec 5 2022, 5:41 PM

mjg requested review of this revision.Dec 5 2022, 5:41 PM

mjg added a reviewer: linuxkpi.

Patch looks mostly good!

sys/compat/linuxkpi/common/include/linux/kref.h
46	This comment can go away.
113	Did you check that the return values are identical here?

mjg added inline comments.Dec 5 2022, 7:00 PM

sys/compat/linuxkpi/common/include/linux/kref.h
46	i'm working on introducing refcount_t
113	i did, it's all fine

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2022, 9:25 AM

Closed by commit rG67e628b7a643: kref: replace hand-rolled atomic ops with refcount API (authored by mjg). · Explain Why

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rG67e628b7a643: kref: replace hand-rolled atomic ops with refcount API.

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2022, 9:25 AM

emaste added inline comments.Dec 13 2022, 8:34 PM

sys/compat/linuxkpi/common/include/linux/kref.h
58	dropping `const` broke drm-kmod

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kref.h

22 lines

Diff 114087

View Options

sys/compat/linuxkpi/common/include/linux/kref.h

kref: replace hand-rolled atomic ops with refcount APIClosedPublicActions