Page MenuHomeFreeBSD
Differential D37608

kref: replace hand-rolled atomic ops with refcount API
ClosedPublic
Actions

Authored by mjg on Dec 5 2022, 5:41 PM.
Tags
None
Referenced Files
F153016882: D37608.id114087.diff
Sat, Apr 18, 3:50 PM
F153016622: D37608.id113859.diff
Sat, Apr 18, 3:47 PM
F153002986: D37608.diff
Sat, Apr 18, 2:05 PM
Unknown Object (File)
Wed, Apr 15, 2:56 AM
Unknown Object (File)
Jan 5 2026, 7:40 PM
Unknown Object (File)
Dec 31 2025, 6:23 AM
Unknown Object (File)
Nov 27 2025, 10:15 PM
Unknown Object (File)
Nov 13 2025, 7:14 AM
View All 72 Files
Subscribers
emaste
• hselasky
imp
linuxkpi

Details

Reviewers
None
Group Reviewers
linuxkpi
Commits
rG67e628b7a643: kref: replace hand-rolled atomic ops with refcount API

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Dec 5 2022, 5:41 PM
Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptDec 5 2022, 5:41 PM
mjg requested review of this revision.Dec 5 2022, 5:41 PM
mjg added a reviewer: linuxkpi.
• hselasky added a subscriber: • hselasky.Dec 5 2022, 5:58 PM

Patch looks mostly good!

sys/compat/linuxkpi/common/include/linux/kref.h
46

This comment can go away.

113

Did you check that the return values are identical here?

mjg added inline comments.Dec 5 2022, 7:00 PM
sys/compat/linuxkpi/common/include/linux/kref.h
46

i'm working on introducing refcount_t

113

i did, it's all fine

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2022, 9:25 AM
Closed by commit rG67e628b7a643: kref: replace hand-rolled atomic ops with refcount API (authored by mjg). · Explain Why
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rG67e628b7a643: kref: replace hand-rolled atomic ops with refcount API.
Herald added a subscriber: imp. · View Herald TranscriptDec 13 2022, 9:25 AM
emaste added inline comments.Dec 13 2022, 8:34 PM
sys/compat/linuxkpi/common/include/linux/kref.h
58

dropping const broke drm-kmod

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
22 lines

Diff 114087

View Options

sys/compat/linuxkpi/common/include/linux/kref.h

Loading...