Differential D37541

rpcgen: Unindent a line not guarded by if (mtflag).
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 21, 7:17 AM

	Unknown Object (File)
	Thu, Nov 20, 11:40 PM

	Unknown Object (File)
	Thu, Nov 20, 11:38 PM

	Unknown Object (File)
	Thu, Nov 20, 11:35 PM

	Unknown Object (File)
	Thu, Nov 20, 11:29 PM

	Unknown Object (File)
	Nov 8 2025, 3:31 AM

	Unknown Object (File)
	Nov 2 2025, 2:05 AM

	Unknown Object (File)
	Oct 30 2025, 1:03 PM

View All 58 Files

Subscribers

Details

Reviewers

emaste
imp

Commits

rGc2c7a43fb5cf: rpcgen: Unindent a line not guarded by if (mtflag).
rG4fa1e855be60: rpcgen: Unindent a line not guarded by if (mtflag).

Summary

mtflag is used to add pthread mutex locking around operations to make
them thread-safe. Setting the state to _SERVED is not conditional on
locking.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 29 2022, 7:55 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 29 2022, 7:55 PM

jhb requested review of this revision.Nov 29 2022, 7:55 PM

Harbormaster completed remote builds in B48542: Diff 113628.Nov 29 2022, 7:55 PM

imp accepted this revision.Nov 29 2022, 8:17 PM

This revision is now accepted and ready to land.Nov 29 2022, 8:17 PM

Was misindented when introduced in ff49530f45dc674ce45ec75d7d33218f97c79b42

Closed by commit rG4fa1e855be60: rpcgen: Unindent a line not guarded by if (mtflag). (authored by jhb). · Explain WhyDec 5 2022, 12:33 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4fa1e855be60: rpcgen: Unindent a line not guarded by if (mtflag)..

jhb added a commit: rGc2c7a43fb5cf: rpcgen: Unindent a line not guarded by if (mtflag)..May 3 2023, 12:30 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

rpcgen/

2 lines

Diff 113817

usr.bin/rpcgen/rpc_svcout.c

Loading...