Page MenuHomeFreeBSD

ktls_test: Add debug option to hexdump keys, nonces, and buffers.
ClosedPublic

Authored by jhb on Nov 27 2022, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 6:05 AM
Unknown Object (File)
Feb 13 2024, 9:32 AM
Unknown Object (File)
Dec 23 2023, 1:30 AM
Unknown Object (File)
Nov 29 2023, 1:31 AM
Unknown Object (File)
Sep 30 2023, 7:13 PM
Unknown Object (File)
Sep 21 2023, 10:20 PM
Unknown Object (File)
Sep 13 2023, 6:31 PM
Unknown Object (File)
Jul 11 2023, 10:55 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 27 2022, 12:15 AM
markj added inline comments.
tests/sys/kern/ktls_test.c
1230

Why not put this after the if (outbuf_len < sizeof(struct tls_record_layer)) check below?

2008

Is this unrelated?

2017

This too. More below.

This revision is now accepted and ready to land.Nov 30 2022, 4:13 PM
This revision now requires review to proceed.Nov 30 2022, 10:06 PM
tests/sys/kern/ktls_test.c
1230

Because you will potentially get it multiple times. If a read returns part of a record we might get to the the read() call for payload data down at line 1242 but not get the full record (so outbuf_len < record_len still). Then on the next kevent we would try to read more of the data, but on that next event we would get down to line 1235 again and print it out a second time.

2008

Oh, yes. I used the medium tests locally when testing NIC TLS offload at Chelsio internally and we needed a case that was bigger than one MSS, but a smaller size was less overwhelming for debugging data. I'll drop all the medium tests from this.

jhb marked 2 inline comments as done.Nov 30 2022, 10:09 PM
This revision is now accepted and ready to land.Dec 5 2022, 2:42 PM