Page MenuHomeFreeBSD

multimedia/librtmp: Fix build with libressl 3.5
AcceptedPublic

Authored by zirias on Mon, Nov 21, 2:27 PM.

Details

Reviewers
hrs
tcberner

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48439
Build 45325: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mon, Nov 21, 3:00 PM

Can we please stop adding sporadic libressl patches to the tree? Upstream and backport.

Can we please stop adding sporadic libressl patches to the tree? Upstream and backport.

This *removes* libressl-checks from *local* patches.

@zirias
This specific patch is a positive change so thank you however it would be nicer if we could avoid having local patches in the first place since you're one of a handful of people that works on libressl support.

@diizzy "upstreaming" patches is a good thing in general (and I did it quite often in the past). With libressl specifically, it won't do any good in most cases. Upstreams that care about libressl are a minority, for them, it makes sense. Most upstreams will either reluctantly or indifferently add some patch (in which case all you get from "usptreaming" is actually MORE work) or outright refuse the patches. IMHO, supporting libressl is only possible by maintaining local patches in the end. Whether FreeBSD ports want to do that or not is something that should be decided.

Back to *this* review, I'm not sure whether we need the patches *at all* now that they don't contain special handling for libressl any more. @hrs can you tell?