multimedia/librtmp: Fix build with libressl 3.8

[zirias]

Summary

Remove all special-casing for libressl from patches. They caused
directly accessing structs that are now opaqued in libressl as well.

[tcberner]

Lgtm

[diizzy]

Can we please stop adding sporadic libressl patches to the tree? Upstream and backport.

[zirias]

In D37454#851589, @diizzy wrote:

Can we please stop adding sporadic libressl patches to the tree? Upstream and backport.

This *removes* libressl-checks from *local* patches.

[diizzy]

@zirias
This specific patch is a positive change so thank you however it would be nicer if we could avoid having local patches in the first place since you're one of a handful of people that works on libressl support.

[zirias]

@diizzy "upstreaming" patches is a good thing in general (and I did it quite often in the past). With libressl specifically, it won't do any good in most cases. Upstreams that care about libressl are a minority, for them, it makes sense. Most upstreams will either reluctantly or indifferently add some patch (in which case all you get from "usptreaming" is actually MORE work) or outright refuse the patches. IMHO, supporting libressl is only possible by maintaining local patches in the end. Whether FreeBSD ports want to do that or not is something that should be decided.

Back to *this* review, I'm not sure whether we need the patches *at all* now that they don't contain special handling for libressl any more. @hrs can you tell?

[zirias]

I totally forgot I was still waiting for maintainer approval on this one. Now it finally popped up in my builds again, so updated and rebased.

I had a closer look btw, the patches will need to stay as upstream code is only compatible with the old/legacy OpenSSL API.