Emacs ports: USE_GCC with NATIVECOMP options
ClosedPublic
Actions

Authored by jrm on Nov 5 2022, 3:17 AM.

Details

Reviewers

ashish
yasu

Commits

R11:8882913727d6: Emacs ports: Build using GCC when NATIVECOMP is on

Summary

In order to allow concurrent GCC ports to be installed, the GCC ports
have started to install some header files in non-standard locations.
Emacs built with NATIVECOMP requires GCC jit libraries, so rather than
patching to search in non-standard locations for their header
files, just build Emacs with GCC when NATIVECOMP is turned on.

PR: 257060

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm created this revision.Nov 5 2022, 3:17 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 5 2022, 3:17 AM

jrm requested review of this revision.Nov 5 2022, 3:17 AM

Harbormaster completed remote builds in B48168: Diff 112642.Nov 5 2022, 3:17 AM

Remove whitespace change

Harbormaster completed remote builds in B48169: Diff 112643.Nov 5 2022, 3:19 AM

Ensure GCC version 11+ is used when building with NATIVECOMP

Harbormaster completed remote builds in B48170: Diff 112644.Nov 5 2022, 3:24 AM

salvadore mentioned this in D37266: lang/gcc11: Install libgccjit.h and libgccjitg++.h in the intended path.Nov 5 2022, 9:44 AM

Looks good to me. I have built editors/emacs successfully after applying the patch in https://reviews.freebsd.org/D37266 for GCC 11 and your patch.

I also confirmed that combination with D37266 works fine on 13.1-RELEASE amd64.

This revision is now accepted and ready to land.Nov 5 2022, 9:54 AM

Yes, this looks good - I have been using USE_GCC=11+ for emacs & NATIVECOMP for a few months now with success. Sorry I forgot to submit the change for review - and thanks for picking it up. -- John

I'll commit just after @salvadore commits D37266. I'll also bump PORTREVSION.