Page MenuHomeFreeBSD
Differential D37247

ping: Remove a vestigial notdef
ClosedPublic
Actions

Authored by jlduran on Nov 3 2022, 9:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 2, 1:39 AM
Unknown Object (File)
Tue, Jun 2, 1:32 AM
Unknown Object (File)
Tue, Jun 2, 12:29 AM
Unknown Object (File)
Tue, Jun 2, 12:23 AM
Unknown Object (File)
Mon, Jun 1, 4:06 PM
Unknown Object (File)
Mon, Jun 1, 11:16 AM
Unknown Object (File)
Sun, May 31, 10:37 AM
Unknown Object (File)
Sun, May 31, 10:32 AM
View All 92 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
markj
Group Reviewers
Contributor Reviews (src)
Commits
rG294cb8bb3acc: ping: Remove a vestigial notdef
rG909e2e1b6c34: ping: Remove a vestigial notdef
Summary

It was once a function on 4.3BSD, pr_type() [1], used to convert an ICMP "type" field to a printable string. In 4.4BSD it was superseded by pr_icmph() [2].

NetBSD [3] and OpenBSD [4] have already removed it.

[1]: https://minnie.tuhs.org/cgi-bin/utree.pl?file=4.3BSD/usr/src/etc/ping.c
[2]: https://minnie.tuhs.org/cgi-bin/utree.pl?file=4.4BSD/usr/src/sbin/ping/ping.c
[3]: https://github.com/NetBSD/src/commit/203dfd34867991fd002f747d74a96f26ae80d41c
[4]: https://github.com/openbsd/src/commit/9bbbbbb75d24e3d166ddd0cb6cb4417b78561309

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Nov 3 2022, 9:52 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2022, 9:52 AM
jlduran requested review of this revision.Nov 3 2022, 9:52 AM
jlduran edited the summary of this revision. (Show Details)Nov 3 2022, 10:14 AM
markj accepted this revision as: markj.Nov 3 2022, 1:06 PM
This revision is now accepted and ready to land.Nov 3 2022, 1:06 PM
markj added a comment.Nov 3 2022, 1:39 PM

Could I ask you to make your git commits available somehow, either by email or in a pull request?

jlduran added a comment.Nov 3 2022, 1:51 PM
In D37247#845961, @markj wrote:

Could I ask you to make your git commits available somehow, either by email or in a pull request?

Absolutely!
https://github.com/freebsd/freebsd-src/pull/624

Closed by commit rG909e2e1b6c34: ping: Remove a vestigial notdef (authored by jlduran, committed by markj). · Explain WhyNov 3 2022, 2:41 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG909e2e1b6c34: ping: Remove a vestigial notdef.
markj added a commit: rG294cb8bb3acc: ping: Remove a vestigial notdef.Nov 10 2022, 5:04 PM

Revision Contents
Changeset List

PathSize
sbin/
ping/
16 lines

Diff 112562

View Options

sbin/ping/ping.c

Loading...