Page MenuHomeFreeBSD

Don't require tty for install-missing-packages
Needs ReviewPublic

Authored by patmaddox on Oct 29 2022, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 21, 11:37 AM
Unknown Object (File)
Tue, May 19, 10:04 PM
Unknown Object (File)
Sun, May 17, 12:26 PM
Unknown Object (File)
Thu, May 14, 2:58 PM
Unknown Object (File)
Thu, May 14, 12:41 PM
Unknown Object (File)
May 13 2026, 4:10 PM
Unknown Object (File)
May 11 2026, 5:11 AM
Unknown Object (File)
May 6 2026, 10:04 PM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

patmaddox created this revision.

This is my first attempt at a code contribution to FreeBSD... hopefully I'm going about it the right way.

Anyway, I came across an issue when running make install-missing-packages on Cirrus CI, which has no TTY. This little change fixes it.

I admittedly don't know what the consequences of this change are. It looks like the -o flag was added in https://reviews.freebsd.org/D23795

Maybe it needs to have some sort of check to see if there's a TTY, and conditionally add the -o?

@0mp @mat @tobik care to weigh in?

the -o is on purpose to preserve interractive prompt, if you want to prevent that, then you need to make this conditionnal to BATCH: if BATCH then xargs pkg install -yA if not xargs -o pkg install -A