Page MenuHomeFreeBSD

Don't require tty for install-missing-packages
AbandonedPublic

Authored by bapt on Oct 29 2022, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 3, 6:16 PM
Unknown Object (File)
Tue, Sep 29, 1:59 PM
Unknown Object (File)
Tue, Sep 29, 2:38 AM
Unknown Object (File)
Sat, Sep 26, 12:02 PM
Unknown Object (File)
Thu, Sep 24, 4:44 AM
Unknown Object (File)
Sun, Sep 20, 5:48 AM
Unknown Object (File)
Sun, Sep 20, 5:04 AM
Unknown Object (File)
Fri, Sep 18, 10:33 PM
Subscribers

Details

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

patmaddox created this revision.

This is my first attempt at a code contribution to FreeBSD... hopefully I'm going about it the right way.

Anyway, I came across an issue when running make install-missing-packages on Cirrus CI, which has no TTY. This little change fixes it.

I admittedly don't know what the consequences of this change are. It looks like the -o flag was added in https://reviews.freebsd.org/D23795

Maybe it needs to have some sort of check to see if there's a TTY, and conditionally add the -o?

@0mp @mat @tobik care to weigh in?

the -o is on purpose to preserve interractive prompt, if you want to prevent that, then you need to make this conditionnal to BATCH: if BATCH then xargs pkg install -yA if not xargs -o pkg install -A

bapt abandoned this revision.
bapt added a reviewer: patmaddox.

I have pushed a proper fix.