Don't require tty for install-missing-packages
Needs ReviewPublic
Actions

Authored by guest-patmaddox on Oct 29 2022, 10:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Oct 11 2024, 7:29 AM

	Unknown Object (File)
	Oct 10 2024, 10:16 PM

	Unknown Object (File)
	Oct 1 2024, 2:14 AM

	Unknown Object (File)
	Sep 16 2024, 4:06 PM

	Unknown Object (File)
	Aug 2 2024, 5:02 AM

	Unknown Object (File)
	Jul 3 2024, 12:34 AM

	Unknown Object (File)
	Jun 24 2024, 10:18 AM

	Unknown Object (File)
	May 27 2024, 11:31 PM

Subscribers

Details

Reviewers

None

Group Reviewers

portmgr

Summary

Fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267416

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

guest-patmaddox requested review of this revision.Oct 29 2022, 10:31 PM

guest-patmaddox created this revision.

This is my first attempt at a code contribution to FreeBSD... hopefully I'm going about it the right way.

Anyway, I came across an issue when running make install-missing-packages on Cirrus CI, which has no TTY. This little change fixes it.

I admittedly don't know what the consequences of this change are. It looks like the -o flag was added in https://reviews.freebsd.org/D23795

Maybe it needs to have some sort of check to see if there's a TTY, and conditionally add the -o?

@0mp @mat @tobik care to weigh in?

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

2 lines

Diff 112391

View Options

Don't require tty for install-missing-packagesNeeds ReviewPublicActions