Page MenuHomeFreeBSD

Don't require tty for install-missing-packages
Needs ReviewPublic

Authored by guest-patmaddox on Oct 29 2022, 10:31 PM.
Tags
None
Referenced Files
F132208153: D37211.id.diff
Tue, Oct 14, 7:23 PM
Unknown Object (File)
Thu, Oct 9, 8:22 PM
Unknown Object (File)
Wed, Oct 8, 9:11 AM
Unknown Object (File)
Sun, Oct 5, 9:14 AM
Unknown Object (File)
Thu, Oct 2, 2:15 PM
Unknown Object (File)
Wed, Oct 1, 5:31 AM
Unknown Object (File)
Sep 13 2025, 8:00 AM
Unknown Object (File)
Sep 4 2025, 4:50 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

guest-patmaddox created this revision.

This is my first attempt at a code contribution to FreeBSD... hopefully I'm going about it the right way.

Anyway, I came across an issue when running make install-missing-packages on Cirrus CI, which has no TTY. This little change fixes it.

I admittedly don't know what the consequences of this change are. It looks like the -o flag was added in https://reviews.freebsd.org/D23795

Maybe it needs to have some sort of check to see if there's a TTY, and conditionally add the -o?

@0mp @mat @tobik care to weigh in?

the -o is on purpose to preserve interractive prompt, if you want to prevent that, then you need to make this conditionnal to BATCH: if BATCH then xargs pkg install -yA if not xargs -o pkg install -A