Page MenuHomeFreeBSD
Differential D37060

Limit MAXCPU <= MAX_APIC_ID assertion to i386
AbandonedPublic
Actions

Authored by emaste on Oct 19 2022, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 3:19 AM
Unknown Object (File)
Thu, Jan 9, 6:58 PM
Unknown Object (File)
Dec 22 2024, 1:06 AM
Unknown Object (File)
Dec 6 2024, 1:40 AM
Unknown Object (File)
Nov 28 2024, 2:47 AM
Unknown Object (File)
Nov 26 2024, 11:26 AM
Unknown Object (File)
Nov 5 2024, 4:30 PM
Unknown Object (File)
Oct 5 2024, 4:44 PM
View All 54 Files
Subscribers
kib

Details

Reviewers
jhb
royger

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Oct 19 2022, 7:32 PM
emaste created this revision.

From @jhb in D36838: the assertion about MAXCPU being <= MAX_APIC_ID is no longer relevant with x2APIC and can be removed I think. I'm not sure if we support x2APIC on i386, so maybe the assertion has to stay for i386 still

emaste mentioned this in D36838: amd64: Bump MAXCPU to 1024 (from 256).Oct 19 2022, 7:33 PM
royger added a comment.Oct 20 2022, 8:19 AM

No, MAX_APIC_ID is also relevant for amd64, as it's used by madt_parse_cpu(), it needs to be bumped to twice the value of MAXCPU I think.

I guess you could have a i386 system with APIC IDs > 0x200, but it's unlikely such system doesn't support amd64.

kib added a comment.Oct 20 2022, 11:25 AM

i386 also uses x2APIC when supported by hardware and not disabled by BIOS.

emaste abandoned this revision.Oct 20 2022, 11:57 AM

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
2 lines

Diff 112006

View Options

sys/x86/x86/mp_x86.c

Loading...