Page MenuHomeFreeBSD

Limit MAXCPU <= MAX_APIC_ID assertion to i386
AbandonedPublic

Authored by emaste on Oct 19 2022, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:34 AM
Unknown Object (File)
Mon, Oct 13, 7:53 AM
Unknown Object (File)
Sun, Oct 5, 12:43 PM
Unknown Object (File)
Tue, Sep 23, 10:38 PM
Unknown Object (File)
Thu, Sep 18, 7:47 AM
Unknown Object (File)
Sep 17 2025, 8:25 AM
Unknown Object (File)
Sep 12 2025, 7:43 PM
Unknown Object (File)
Sep 9 2025, 1:07 AM
Subscribers

Details

Reviewers
jhb
royger

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.

From @jhb in D36838: the assertion about MAXCPU being <= MAX_APIC_ID is no longer relevant with x2APIC and can be removed I think. I'm not sure if we support x2APIC on i386, so maybe the assertion has to stay for i386 still

No, MAX_APIC_ID is also relevant for amd64, as it's used by madt_parse_cpu(), it needs to be bumped to twice the value of MAXCPU I think.

I guess you could have a i386 system with APIC IDs > 0x200, but it's unlikely such system doesn't support amd64.

i386 also uses x2APIC when supported by hardware and not disabled by BIOS.