Limit MAXCPU <= MAX_APIC_ID assertion to i386
AbandonedPublic
Actions

Authored by emaste on Oct 19 2022, 7:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 6, 1:40 AM

	Unknown Object (File)
	Thu, Nov 28, 2:47 AM

	Unknown Object (File)
	Tue, Nov 26, 11:26 AM

	Unknown Object (File)
	Nov 5 2024, 4:30 PM

	Unknown Object (File)
	Oct 5 2024, 4:44 PM

	Unknown Object (File)
	Oct 5 2024, 8:55 AM

	Unknown Object (File)
	Oct 3 2024, 9:42 AM

	Unknown Object (File)
	Oct 3 2024, 1:43 AM

View All 51 Files

Subscribers

kib

Details

Reviewers

jhb
royger

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

From @jhb in D36838: the assertion about MAXCPU being <= MAX_APIC_ID is no longer relevant with x2APIC and can be removed I think. I'm not sure if we support x2APIC on i386, so maybe the assertion has to stay for i386 still

emaste mentioned this in D36838: amd64: Bump MAXCPU to 1024 (from 256).Oct 19 2022, 7:33 PM

No, MAX_APIC_ID is also relevant for amd64, as it's used by madt_parse_cpu(), it needs to be bumped to twice the value of MAXCPU I think.

I guess you could have a i386 system with APIC IDs > 0x200, but it's unlikely such system doesn't support amd64.

i386 also uses x2APIC when supported by hardware and not disabled by BIOS.

emaste abandoned this revision.Oct 20 2022, 11:57 AM

Revision Contents
Changeset List

Path

Size

sys/

x86/

mp_x86.c

2 lines

Diff 112006

View Options

Limit MAXCPU <= MAX_APIC_ID assertion to i386AbandonedPublicActions