Fix nfscl_getmyip() so that it does not cause a crash post commit efe58855f3ea
ClosedPublic
Actions

Authored by rmacklem on Oct 14 2022, 11:09 PM.

Details

Reviewers

Commits

rG7d9dc91a9901: nfscl: Fix the NFSv4.0 mount so that it does not crash

Summary

Commit efe58855f3ea modifies IN_LOOPBACK() so that it uses a VNET
variable. Without this patch, nfscl_getmyip() uses IN_LOOPBACK()
when the VNET is not set and crashes the system.

This patch re-organizes nfscl_getmyip() so that IN_LOOPBACK()
is before the CURVENT_RESTORE() macro, to avoid the crashes.

Test Plan

Tested by doing a NFSv4.0 mount and seeing it did
not crash the system.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rmacklem created this revision.Oct 14 2022, 11:09 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 14 2022, 11:09 PM

rmacklem requested review of this revision.Oct 14 2022, 11:09 PM

Looks good to me.

karels accepted this revision.Oct 15 2022, 2:53 AM

This revision is now accepted and ready to land.Oct 15 2022, 2:53 AM

Closed by commit rG7d9dc91a9901: nfscl: Fix the NFSv4.0 mount so that it does not crash (authored by rmacklem). · Explain WhyOct 15 2022, 3:40 PM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rG7d9dc91a9901: nfscl: Fix the NFSv4.0 mount so that it does not crash.

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfsclient/

nfs_clport.c

16 lines

Diff 111827

View Options

sys/fs/nfsclient/nfs_clport.c

Fix nfscl_getmyip() so that it does not cause a crash post commit efe58855f3eaClosedPublicActions