Differential D3690

rum(4): fix stats interpretation in rum_ratectl_task()
ClosedPublic
Actions

Authored by avos on Sep 17 2015, 3:02 PM.

Details

Reviewers

None

Group Reviewers

Contributor Reviewers (ports)

Commits

rS288639: rum(4): fix stats interpretation in rum_ratectl_task()

Test Plan

Tested on WUSB54GC, STA mode

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 8819.Sep 17 2015, 3:02 PM

avos retitled this revision from to rum(4): fix stats interpretation in rum_ratectl_task().

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptSep 17 2015, 3:02 PM

Herald added a subscriber: imp. · View Herald Transcript

avos added a parent revision: D3689: rum(4): set short/long retry limits.Sep 17 2015, 3:04 PM

hi,

Just a note - when you change hardware stuff like this, can you please include where you're sourcing things like register changes, usage, etc?

In D3690#78165, @adrian wrote:

hi,

Just a note - when you change hardware stuff like this, can you please include where you're sourcing things like register changes, usage, etc?

Yes:

http://mirror.robert-marquardt.com/downloads/DSRT2571W_V3-1.3_062207.pdf
manual testing:
- print all statistic values from rum_ratectl_task() (every second);
- and, then, test it with:

a) ifconfig wlan1 maxretry 0;
b) ifconfig wlan1 maxretry 1;
c) ifconfig wlan1 maxretry 2;
d) ifconfig wlan1 maxretry 9;
(note: you must merge D3689 before trying to set maxretry parameter)
+ monitor all traffic & compare results.

Closed by commit rS288639: rum(4): fix stats interpretation in rum_ratectl_task() (authored by adrian). · Explain WhyOct 3 2015, 10:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_rum.c

37 lines

Diff 9112

View Options

head/sys/dev/usb/wlan/if_rum.c

rum(4): fix stats interpretation in rum_ratectl_task()ClosedPublicActions