msk: Don't bother reading spare stats registers.
ClosedPublic
Actions

Authored by jhb on Oct 3 2022, 11:21 PM.

Details

Reviewers

emaste
imp

Commits

rGd77e67e9d5e4: msk: Don't bother reading spare stats registers.
rGaabbe26939be: msk: Don't bother reading spare stats registers.

Summary

msk_stats_update reads stats registers named "spare" whose values are
discarded.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 3 2022, 11:21 PM

jhb created this revision.

Harbormaster completed remote builds in B47685: Diff 111399.Oct 3 2022, 11:21 PM

jhb added a child revision: D36777: msk: Use a void cast to mark values of dummy reads as unused..Oct 3 2022, 11:22 PM

I suppose it's possible some incredibly poorly designed hardware could require that all of the registers be read, but I'm sure that's not the case here.

This revision is now accepted and ready to land.Oct 4 2022, 1:02 PM

imp accepted this revision.Oct 4 2022, 7:31 PM

Closed by commit rGaabbe26939be: msk: Don't bother reading spare stats registers. (authored by jhb). · Explain WhyOct 5 2022, 11:48 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGaabbe26939be: msk: Don't bother reading spare stats registers..

jhb added a commit: rGd77e67e9d5e4: msk: Don't bother reading spare stats registers..Nov 11 2022, 6:39 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

msk/

if_msk.c

4 lines

Diff 111490

View Options

msk: Don't bother reading spare stats registers.ClosedPublicActions