Page MenuHomeFreeBSD
Differential D36847

show_sysctl_all: reduce copying, please coverity
ClosedPublic
Actions

Authored by dougm on Sep 30 2022, 10:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 16, 1:19 PM
Unknown Object (File)
Wed, Nov 12, 6:23 AM
Unknown Object (File)
Mon, Oct 27, 3:50 PM
Unknown Object (File)
Oct 21 2025, 9:51 PM
Unknown Object (File)
Oct 10 2025, 4:37 AM
Unknown Object (File)
Oct 10 2025, 4:37 AM
Unknown Object (File)
Oct 10 2025, 4:37 AM
Unknown Object (File)
Oct 9 2025, 11:17 PM
View All 71 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rGe5f93d10782d: show_sysctl_all: reduce copying, please coverity
Summary

Modify db_show_sysctl_all so that it does not copy more than once the data of the input oid, and so that what it passes to db_show_oid does not alarm coverity.

I had to do a little extra work so that I wouldn't be asking you to review your own code.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Sep 30 2022, 10:14 PM
dougm created this revision.
markj accepted this revision.Oct 1 2022, 2:40 PM
This revision is now accepted and ready to land.Oct 1 2022, 2:40 PM
Closed by commit rGe5f93d10782d: show_sysctl_all: reduce copying, please coverity (authored by dougm). · Explain WhyOct 1 2022, 5:22 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGe5f93d10782d: show_sysctl_all: reduce copying, please coverity.
Herald added a subscriber: imp. · View Herald TranscriptOct 1 2022, 5:22 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
47 lines

Diff 111305

View Options

sys/kern/kern_sysctl.c

Loading...