Differential D36780

qat: Fix build with GCC.
ClosedPublic
Actions

Authored by jhb on Sep 28 2022, 9:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 18, 11:27 PM

	Unknown Object (File)
	Wed, Apr 15, 12:55 PM

	Unknown Object (File)
	Wed, Apr 15, 8:45 AM

	Unknown Object (File)
	Tue, Apr 14, 9:17 AM

	Unknown Object (File)
	Sat, Apr 11, 3:56 AM

	Unknown Object (File)
	Fri, Apr 10, 5:14 AM

	Unknown Object (File)
	Fri, Apr 3, 10:42 AM

	Unknown Object (File)
	Thu, Apr 2, 4:14 PM

Subscribers

Details

Reviewers

markj
MichalX.Gulbicki_intel.com

Commits

rGcdfe82d35abb: qat: Fix build with GCC.

Summary

Use the correct option to suppress warnings due to discarding const
from pointers on GCC vs clang.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 28 2022, 9:15 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2022, 9:15 PM

jhb requested review of this revision.Sep 28 2022, 9:15 PM

Harbormaster completed remote builds in B47592: Diff 111160.Sep 28 2022, 9:15 PM

jhb added a parent revision: D36779: qat: Remove non-existent path from -I..Sep 28 2022, 9:15 PM

jhb added a reviewer: MichalX.Gulbicki_intel.com.Sep 28 2022, 9:17 PM

markj accepted this revision.Sep 28 2022, 9:18 PM

markj added inline comments.

sys/modules/qat/qat/Makefile
24	How did this work with clang? IIRC setting CWARNFLAGS before including bsd.(kmod\|prog\|...).mk has no effect.

This revision is now accepted and ready to land.Sep 28 2022, 9:18 PM

jhb added inline comments.Sep 28 2022, 9:42 PM

sys/modules/qat/qat/Makefile
24	Setting the per-file CWARNFLAGS works fine as that gets appended to CWARNFLAGS for a given file later. However, in this case I needed bsd.kmod.mk to include bsd.compiler.mk to define COMPILER_TYPE.

Closed by commit rGcdfe82d35abb: qat: Fix build with GCC. (authored by jhb). · Explain WhySep 29 2022, 10:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGcdfe82d35abb: qat: Fix build with GCC..

Revision Contents
Changeset List

Path

Size

sys/

modules/

qat/

qat/

9 lines

Diff 111221

sys/modules/qat/qat/Makefile

Loading...