Turn readline into an internallib for gdb
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
This looks good to me, but I'm not entirely sure this is the right way to do this, but I can't offer a constructive comment on how to make it better.
Comment Actions
If gdb is the only in-tree consumer of libreadline, can we just statically link it into gdb and remove the .so entirely?
Comment Actions
Or, right, sorry. I misunderstood and thought it was being moved into private. Reading it a bit more carefully, it looks fine.
Comment Actions
Can you add the UPADTING entry in here too? This passed an exp run already, correct?
Be sure to highlight reasons for removing it in the commit message - e.g., having ports use readline from ports allows it to be kept up-to-date. Specifically, it's not just because of the GPL that it's being removed.
ObsoleteFiles.inc | ||
---|---|---|
42 | OLD_LIBS= | |
49 | OLD_LIBS= |
Comment Actions
Here's my take:
20140707: The GNU readline library is now an INTERNALLIB - that is, it is statically linked into consumers (GDB and variants) in the base system, and the shared library is no longer installed. The devel/readline port is available for third party software that requires readline.