Page MenuHomeFreeBSD

git-arc: Cope with extra output
ClosedPublic

Authored by imp on Sep 14 2022, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 10:32 AM
Unknown Object (File)
Fri, Apr 19, 10:50 PM
Unknown Object (File)
Fri, Apr 19, 10:50 PM
Unknown Object (File)
Fri, Apr 19, 10:49 PM
Unknown Object (File)
Fri, Apr 19, 10:22 PM
Unknown Object (File)
Wed, Apr 17, 11:17 AM
Unknown Object (File)
Apr 7 2024, 6:08 AM
Unknown Object (File)
Jan 15 2024, 2:55 AM
Subscribers
None

Details

Summary

On my machine, for reasons beyond my understanding, I get this warning
two times when running arc:

Warning: Module "openssl" is already loaded in Unknown on line 0

so grep -v ^Warning: on all the arc call-conduit calls to filter them
out so we can properly parse the JSON with jq.

Sponsored by: Netflix

Test Plan

This, and the prior review, gets me to a working git arc again.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 14 2022, 8:07 PM
imp created this revision.
imp added reviewers: jhb, markj.

Same comment as the other review: can we handle this in a subroutine?

do the filtering routine that markj wanted

markj added inline comments.
tools/tools/git/git-arc.sh
153

Why "$*" and not "$@"?

This revision is now accepted and ready to land.May 7 2023, 5:41 PM
tools/tools/git/git-arc.sh
153

Old habits die hard... the Solaris shell had issues with that... or maybe it was sunos... but v7 she'll it works... I'll update

use "$@" since that expands to something we want, unlike $* which doesn't
(see the manual for the subtle differences)

This revision now requires review to proceed.May 8 2023, 11:30 PM
This revision is now accepted and ready to land.May 9 2023, 2:04 PM
This revision was automatically updated to reflect the committed changes.