Differential D36495

Minor fixes to acpi_thermal
ClosedPublic
Actions

Authored by jo_bruelltuete.com on Sep 8 2022, 3:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 25, 9:18 AM

	Unknown Object (File)
	Tue, Mar 24, 12:49 PM

	Unknown Object (File)
	Mon, Mar 23, 12:18 AM

	Unknown Object (File)
	Sun, Mar 22, 7:05 AM

	Unknown Object (File)
	Mon, Mar 16, 1:02 PM

	Unknown Object (File)
	Sun, Mar 15, 9:11 AM

	Unknown Object (File)
	Sat, Mar 14, 9:14 AM

	Unknown Object (File)
	Fri, Mar 6, 7:41 PM

Subscribers

Details

Reviewers

Commits

rGa9a267c1f7a5: acpi_thermal: Fix a potential stack buffer overflow.

Summary

Fix typo.
Fix potential stack buffer overflow.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jo_bruelltuete.com created this revision.Sep 8 2022, 3:39 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2022, 3:39 PM

jo_bruelltuete.com requested review of this revision.Sep 8 2022, 3:39 PM

jo_bruelltuete.com added inline comments.Sep 8 2022, 3:43 PM

sys/dev/acpica/acpi_thermal.c
179	typo
260	potential (unlikely) buffer overflow. with device unit being an int, the string oidname can be 13 bytes long (only 8 bytes where allocd on the stack): "tz1073741823_" (with _ being the null terminator).

hi john, adding you as you've made recent changes here.
thanks for looking!

use snprintf as well

jhb accepted this revision.Sep 30 2022, 9:15 PM

This revision is now accepted and ready to land.Sep 30 2022, 9:15 PM

Can you please confirm the e-mail address and name to use for the commit author when merging this?

Thanks!

In D36495#836211, @jhb wrote:

Can you please confirm the e-mail address and name to use for the commit author when merging this?

Johannes Totz, jo@bruelltuete.com

thanks!

Closed by commit rGa9a267c1f7a5: acpi_thermal: Fix a potential stack buffer overflow. (authored by jo_bruelltuete.com, committed by jhb). · Explain WhyOct 3 2022, 6:23 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa9a267c1f7a5: acpi_thermal: Fix a potential stack buffer overflow..

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

6 lines

Diff 111366

sys/dev/acpica/acpi_thermal.c

Loading...