Page MenuHomeFreeBSD

Minor fixes to acpi_thermal
ClosedPublic

Authored by jo_bruelltuete.com on Sep 8 2022, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 4:42 PM
Unknown Object (File)
Sat, Oct 11, 4:53 AM
Unknown Object (File)
Sat, Oct 11, 1:10 AM
Unknown Object (File)
Fri, Oct 10, 11:05 AM
Unknown Object (File)
Fri, Oct 10, 11:05 AM
Unknown Object (File)
Fri, Oct 10, 4:28 AM
Unknown Object (File)
Fri, Oct 10, 4:28 AM
Unknown Object (File)
Thu, Oct 9, 11:10 PM
Subscribers

Details

Summary

Fix typo.
Fix potential stack buffer overflow.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/acpica/acpi_thermal.c
179

typo

260

potential (unlikely) buffer overflow.
with device unit being an int, the string oidname can be 13 bytes long (only 8 bytes where allocd on the stack): "tz1073741823_" (with _ being the null terminator).

hi john, adding you as you've made recent changes here.
thanks for looking!

This revision is now accepted and ready to land.Sep 30 2022, 9:15 PM

Can you please confirm the e-mail address and name to use for the commit author when merging this?

Thanks!

In D36495#836211, @jhb wrote:

Can you please confirm the e-mail address and name to use for the commit author when merging this?

Johannes Totz, jo@bruelltuete.com

thanks!