Page MenuHomeFreeBSD

textproc/fcitx5-qt: Add Qt6 support and split into qt5, qt6, common FLAVORS
ClosedPublic

Authored by lwhsu on Aug 31 2022, 8:33 PM.
Tags
None
Referenced Files
F132435198: D36408.id110025.diff
Thu, Oct 16, 10:23 PM
Unknown Object (File)
Wed, Oct 15, 11:32 PM
Unknown Object (File)
Wed, Oct 15, 12:45 PM
Unknown Object (File)
Tue, Oct 14, 2:29 AM
Unknown Object (File)
Sun, Oct 12, 2:50 PM
Unknown Object (File)
Thu, Oct 9, 6:51 PM
Unknown Object (File)
Thu, Oct 9, 7:00 AM
Unknown Object (File)
Fri, Oct 3, 9:58 AM
Subscribers

Details

Summary

I know that the USES in each flavor can be sorted more, but let's check if
this direction makes sense first.

I haven't decided yet that we should bump fcitx5-qt's PORTREVISION to make it
5.0.8_1, or rename qt5 flavor package to fcitx5-qt5 and keep 5.0.8 version.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lwhsu requested review of this revision.Aug 31 2022, 8:33 PM
textproc/fcitx5-qt/Makefile
23

^ how about 5 for symmmetry?

29

CMAKE_OFF=ENABLE_QT4 could be extraced outside the ifs. Also, we don't have Qt4 for years now, so maybe just drop it :)

35

^ I think you should enforce >=${DISTVERSION} here, as you want to be in sync most likely

Addressing comments, split textproc/fcitx5-qt-common to slave port because self-dependency problem

lwhsu marked 2 inline comments as done.Sep 6 2022, 8:23 PM
lwhsu added inline comments.
textproc/fcitx5-qt/Makefile
29

?= here for slave port.

lwhsu marked an inline comment as done.

Rebase

This revision is now accepted and ready to land.Oct 10 2022, 7:05 AM
This revision was automatically updated to reflect the committed changes.