Page MenuHomeFreeBSD

Make the CPU width a macro
Needs ReviewPublic

Authored by andrew on Aug 25 2022, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 12:57 PM
Unknown Object (File)
Sun, Oct 19, 12:57 PM
Unknown Object (File)
Sat, Oct 18, 10:20 PM
Unknown Object (File)
Sat, Oct 18, 5:25 AM
Unknown Object (File)
Fri, Sep 26, 10:31 PM
Unknown Object (File)
Thu, Sep 25, 12:08 PM
Unknown Object (File)
Sep 18 2025, 12:43 PM
Unknown Object (File)
Sep 9 2025, 1:46 AM
Subscribers

Details

Reviewers
None
Group Reviewers
pmc
Summary

This allows us to increase it later when 1000 core machines are
available. For now make it 3 digits to support the current > 99 core
machines.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47126
Build 44013: arc lint + arc unit

Event Timeline

bz added inline comments.
usr.sbin/pmcstat/pmcstat.c
123

This may sound weird, but how far are we off from 4 digits? I understand that in academia 1088 core RISC-V exists...

123

also PMC_CPU_STR_WIDTH as it CPU_WIDTH could easily be confused with 32 vs. 64 vs. 128 bit?

emaste added inline comments.
usr.sbin/pmcstat/pmcstat.c
123

Not too far; I expect to have 768 in my office shortly and will almost certainly have > 1000 during 15.x's lifetime. But committing this as a NFC first (with the macro staying at 3) makes sense to me.