Page MenuHomeFreeBSD

Make the CPU width a macro
Needs ReviewPublic

Authored by andrew on Aug 25 2022, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 5:49 AM
Unknown Object (File)
Dec 5 2024, 2:29 PM
Unknown Object (File)
Oct 24 2024, 10:10 PM
Unknown Object (File)
Oct 23 2024, 11:04 AM
Unknown Object (File)
Oct 17 2024, 11:00 AM
Unknown Object (File)
Oct 7 2024, 4:38 AM
Unknown Object (File)
Oct 4 2024, 4:39 AM
Unknown Object (File)
Oct 3 2024, 11:56 PM
Subscribers

Details

Reviewers
None
Group Reviewers
pmc
Summary

This allows us to increase it later when 1000 core machines are
available. For now make it 3 digits to support the current > 99 core
machines.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47126
Build 44013: arc lint + arc unit

Event Timeline

bz added inline comments.
usr.sbin/pmcstat/pmcstat.c
123

This may sound weird, but how far are we off from 4 digits? I understand that in academia 1088 core RISC-V exists...

123

also PMC_CPU_STR_WIDTH as it CPU_WIDTH could easily be confused with 32 vs. 64 vs. 128 bit?

emaste added inline comments.
usr.sbin/pmcstat/pmcstat.c
123

Not too far; I expect to have 768 in my office shortly and will almost certainly have > 1000 during 15.x's lifetime. But committing this as a NFC first (with the macro staying at 3) makes sense to me.