Fix default login class for services started via command line; allow service class in /etc/login.conf to be overridden.

[allanjude]

etc/rc.subr

771 ↗

(On Diff #8659)

should we just call it ${name}_class instead of ${name}_login_class? it really doesn't have much to do with 'login'

[dteske]

Agreed that Hunk #1 (curfiles) is not subject to review.

Hunk #3 is completely unnecessary (assigning default value for _login_class).
Hunk #4 can be simplified to the following (again, Hunk #3 removed):

1060: # Prepend default limits
1061: _doit="limits -C ${_login_class:-daemon} $_doit"

Alternatively, if you think that future code may want to inherit the default, keep Hunk #3 but change it to:

: ${_login_class:=daemon}

And don't modify Hunk #4.

[dteske]

etc/rc.subr

947 ↗

(On Diff #8659)

After some thought, I think the best solution is:

947: _prepend=\$${name}_prepend _login_class=\${${name}_login_class:-daemon}

Then, remove lines 948-952 below. With that, this patch would be ready to sail.

[adrian]

Address devin's feedback.