Page MenuHomeFreeBSD

PVH: support whitespace cmdline splitting
ClosedPublic

Authored by cperciva on Aug 13 2022, 12:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 15 2022, 4:42 PM
Unknown Object (File)
Dec 15 2022, 7:49 AM
Unknown Object (File)
Dec 13 2022, 10:56 AM
Subscribers

Details

Summary

For historical reasons, Xen kernel command lines have options
separated by commas. Every other FreeBSD platform uses whitespace;
this is also necessary in PVH in order to support the Firecracker
VMM. Allow options to be separated by any combination of commas
and whitespace.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Though some things are like "gee=woo foo=bar,baz,bing" will now be misparsed.

This revision is now accepted and ready to land.Aug 13 2022, 3:10 PM
In D36190#821461, @imp wrote:

Though some things are like "gee=woo foo=bar,baz,bing" will now be misparsed.

Yeah, that's an unavoidable consequence of wanting to support Xen's historical use of commas as argument separators. Maybe at some point we should switch to only using commas here if we're booting under Xen, but accepting both commas and whitespace is good enough for now, I think.

This revision was automatically updated to reflect the committed changes.