local_unbound: rc: allow to overwrite pid file path
ClosedPublic
Actions

Authored by bz on Aug 11 2022, 2:34 PM.

Details

Reviewers

cy
0mp

Group Reviewers

Commits

rGfe67d3255027: local_unbound: rc: allow to overwrite pid file path
rGe19631737085: local_unbound: rc: allow to overwrite pid file path

Summary

Certain configurations need to use a different path for pidfile.
Allow rc.conf to overwrite it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Aug 11 2022, 2:34 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 11 2022, 2:34 PM

bz requested review of this revision.Aug 11 2022, 2:34 PM

Harbormaster completed remote builds in B46860: Diff 109164.Aug 11 2022, 2:34 PM

0mp requested changes to this revision.Aug 19 2022, 9:08 AM

0mp added a subscriber: 0mp.

0mp added inline comments.

libexec/rc/rc.d/local_unbound
37	This should probably be called local_unbound_pidfile for consistency with other services.

This revision now requires changes to proceed.Aug 19 2022, 9:08 AM

Rename to _pidfile as requested by @0mp

Harbormaster completed remote builds in B47130: Diff 109854.Aug 25 2022, 5:34 PM

bz marked an inline comment as done.Aug 31 2022, 10:34 PM

LGTM

0mp accepted this revision.Sep 1 2022, 4:14 PM

This revision is now accepted and ready to land.Sep 1 2022, 4:14 PM

Closed by commit rGe19631737085: local_unbound: rc: allow to overwrite pid file path (authored by bz). · Explain WhySep 1 2022, 11:54 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGe19631737085: local_unbound: rc: allow to overwrite pid file path.

bz added a commit: rGfe67d3255027: local_unbound: rc: allow to overwrite pid file path.Sep 21 2022, 2:02 PM

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.d/

local_unbound

2 lines

Diff 110067

View Options

libexec/rc/rc.d/local_unbound

local_unbound: rc: allow to overwrite pid file pathClosedPublicActions