Page MenuHomeFreeBSD
Differential D35954

emulators/virtualbox-ose-additions: Remove devclass from DRIVER_MODULE on recent main.
ClosedPublic
Actions

Authored by jhb on Jul 26 2022, 6:38 PM.
Tags
None
Referenced Files
F82200701: D35954.id109678.diff
Fri, Apr 26, 10:28 AM
F82200619: D35954.id108564.diff
Fri, Apr 26, 10:26 AM
F82200328: D35954.id.diff
Fri, Apr 26, 10:20 AM
F82165630: D35954.diff
Fri, Apr 26, 3:02 AM
Unknown Object (File)
Mon, Apr 22, 8:15 AM
Unknown Object (File)
Sat, Apr 20, 5:34 AM
Unknown Object (File)
Mar 22 2024, 7:59 AM
Unknown Object (File)
Mar 22 2024, 7:59 AM
View All 50 Files
Subscribers
madpilot
mat

Details

Reviewers
madpilot
Group Reviewers
vbox
Commits
R11:8b07c8afd6ff: emulators/virtualbox-ose-additions: Remove devclass from DRIVER_MODULE on…

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 46605
Build 43494: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 26 2022, 6:38 PM
Herald added a subscriber: mat. · View Herald TranscriptJul 26 2022, 6:38 PM
jhb requested review of this revision.Jul 26 2022, 6:38 PM
Harbormaster completed remote builds in B46605: Diff 108564.Jul 26 2022, 6:38 PM
jhb added a child revision: D35168: *DRIVER_MODULE*: Remove the compat shims to accept the devclass argument..Jul 26 2022, 6:38 PM
jhb added a comment.Aug 12 2022, 5:25 PM

Ping?

madpilot accepted this revision.Aug 12 2022, 5:42 PM
madpilot added a subscriber: madpilot.

I'm approving since I guess you already tested it and looks correct, but I'm unable to test this till late next week.

This revision is now accepted and ready to land.Aug 12 2022, 5:42 PM
madpilot added a comment.EditedAug 18 2022, 1:44 PM

Hi,

I tested this patch at runtime and it works fine.

Thanks!

P.S. Sorry, please hold a little, I now noticed I did not properly test this. Give me a little more time!

madpilot added a comment.Aug 18 2022, 2:17 PM

Hi again. A first test on 13.1 is not working. Which is strange, this should be a NOP there, if I understand correctly.

It's going to a black screen in the VM when starting Xorg.

I need more time to test on head and verify my findings.

madpilot added a comment.Aug 19 2022, 2:08 PM

I'm having a problem properly testing this.

I'm stumbling on other issues.

On 13.1 the module loads ands seems to work though. What is broken there for me at present, using the head of the ports repo is the virtualbox X11 driver.

On head (installed from FreeBSD-14.0-CURRENT-amd64-20220812-6a70a0c8bfa-257314-disc1.iso) I get a kernel panic due to a giant locking issue, both with and without your patch.

I'm trying to understand what is going on. More help would be appreciated, since I have no idea what could be causing these two issues.

Closed by commit R11:8b07c8afd6ff: emulators/virtualbox-ose-additions: Remove devclass from DRIVER_MODULE on… (authored by jhb). · Explain WhyAug 22 2022, 6:15 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: R11:8b07c8afd6ff: emulators/virtualbox-ose-additions: Remove devclass from DRIVER_MODULE on….

Revision Contents
Changeset List

Diff 108564

View Options

emulators/virtualbox-ose/files/patch-src-VBox-Additions-common-VBoxGuest-VBoxGuest-freebsd.c

Loading...
View Options

emulators/virtualbox-ose/files/patch-src_VBox_Additions_freebsd_drm_vboxvideo__drm.c

Loading...