Push #include "opt_random.h" down into !KLD_MODULE block to reduce opt_random.h pollution with modules that include sys/random.h
AbandonedPublic
Actions

Authored by ngie on Sep 7 2015, 9:06 PM.

Details

Reviewers

markm
imp

Summary

Reduce opt_random.h pollution with kernel modules

Push #include "opt_random.h" down into !KLD_MODULE block to reduce
opt_random.h pollution with modules that include sys/random.h, as
RANDOM_LOADABLE and RANDOM_YARROW are only tested there.

This reduces the additional header pollution added via r286839

Test Plan

kernel build/install pending

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 433
Build 433: arc lint + arc unit

Event Timeline

ngie updated this revision to Diff 8566.Sep 7 2015, 9:06 PM

ngie retitled this revision from to Push #include "opt_random.h" down into !KLD_MODULE block to reduce opt_random.h pollution with modules that include sys/random.h.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: markm.

ngie added a subscriber: avg.

Herald added a subscriber: imp. · View Herald TranscriptSep 7 2015, 9:06 PM

There's another review that fixes this right. Do not commit this. It breaks modules. Don't do that. Please.

The proper fix is to move all the opt_random.h stuff into opt_global.h and simply delete opt_random.h
from everywhere.

This revision now requires changes to proceed.Sep 7 2015, 10:24 PM

See D3486. Commit that instead if the author hasn't done it yet.

I'll wait for the other revision to materialize.

Revision Contents
Changeset List

Path

Size

sys/

random.h

3 lines

Diff 8566

View Options

Push #include "opt_random.h" down into !KLD_MODULE block to reduce opt_random.h pollution with modules that include sys/random.hAbandonedPublicActions