etdump: exit on error if section header or entry offset is OOB
ClosedPublic
Actions

Authored by emaste on Jul 20 2022, 4:27 PM.

Details

Reviewers

jrtc27
imp
markj

Commits

rG3976ad45bb06: etdump: exit on error if section header or entry offset is OOB
rGdc3d0ff61575: etdump: exit on error if section header or entry offset is OOB
rGddf77ec39271: etdump: exit on error if section header or entry offset is OOB

Summary

PR: 263663

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jul 20 2022, 4:27 PM

emaste created this revision.

emaste added a reviewer: jrtc27.

emaste added a reviewer: imp.Jul 21 2022, 1:32 PM

emaste added a reviewer: markj.Mar 2 2023, 1:23 AM

markj added inline comments.Mar 2 2023, 6:33 PM

usr.bin/etdump/etdump.c
201	Do we also need a bounds check here?

emaste added inline comments.Mar 22 2023, 1:22 AM

usr.bin/etdump/etdump.c
201	that `entry[0]` is not out of bounds?

markj accepted this revision.Mar 22 2023, 1:02 PM

markj added inline comments.

usr.bin/etdump/etdump.c
201	Sorry, not sure what I was thinking. The loop condition is enough.

This revision is now accepted and ready to land.Mar 22 2023, 1:02 PM

Closed by commit rGddf77ec39271: etdump: exit on error if section header or entry offset is OOB (authored by emaste). · Explain WhyMar 22 2023, 1:13 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGddf77ec39271: etdump: exit on error if section header or entry offset is OOB.

emaste added a commit: rGdc3d0ff61575: etdump: exit on error if section header or entry offset is OOB.Mar 23 2023, 12:50 PM

emaste added a commit: rG3976ad45bb06: etdump: exit on error if section header or entry offset is OOB.Mar 23 2023, 12:53 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

etdump/

etdump.c

14 lines

Diff 119243

View Options

etdump: exit on error if section header or entry offset is OOBClosedPublicActions