Page MenuHomeFreeBSD

Disallow invalid PT_GNU_STACK
ClosedPublic

Authored by emaste on Jul 20 2022, 4:25 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.
This revision is now accepted and ready to land.Jul 20 2022, 4:31 PM

Did you looked at where the reported 'hang' occur? I suspect the actual bug is elsewere. I would expect that copyout_strings() would just error out, could we leak the vnode lock?

I admit I did not look further and have not created a binary with corrupted PT_GNU_STACK [also asked the original submitter in PR, but got no response], but I will try to take a look either before committing this or with it reverted.

I will try to take a look either before committing this or with it reverted.

I did not get a chance to do it yet, will eventually try reverting it and continuing to investigate.

This revision was automatically updated to reflect the committed changes.