Page MenuHomeFreeBSD

sysutils/vm-bhyve-devel: add new port
ClosedPublic

Authored by driesm on Jul 9 2022, 9:36 AM.

Details

Summary

Contrary to the sysutils/vm-bhyve port which tracks releases,
this port will track the head of the main branch. The main reason
is that upstream has become stale in creating releases. This way
we atleast get some improvements that have not yet been included
in a release. Last release dates from January 2020.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

driesm requested review of this revision.Jul 9 2022, 9:36 AM
0mp requested changes to this revision.Jul 9 2022, 11:59 AM
0mp added inline comments.
sysutils/vm-bhyve-devel/Makefile
0–1

This has to be something different. Ideally, use git describe --tags to get the version. See the porters handbook for details.

Also, if there are some patches in the PRs that are worth bringing in, use PATCH_SITES and PATCHFILES. See the ports tree for examples.

sysutils/vm-bhyve-devel/pkg-message
20

I'd drop that. It's not relevant as it is a new port.

sysutils/vm-bhyve/Makefile
3

I'm not sure if that's necessary, but my guess is that if we want the conflict information to be included in the vm-bhyve package, we have to bump the revision here. So it seems correct.

This revision now requires changes to proceed.Jul 9 2022, 11:59 AM

Also, great idea. I've been thinking about doing it myself a couple of time!

  • Use decent versioning based on git describe --tags
  • Drop upgrade note as its a new port
driesm marked 2 inline comments as done.

@FreeBSD not @Freeebsd

sysutils/vm-bhyve-devel/Makefile
0–1

Nice! Will definitely remember this one.

sysutils/vm-bhyve/Makefile
3

That was my reasoning too, it might work if its already in the vm-bhyve-devel port when trying to install it. To be sure I'll bump it.

Actually fix it (@FreeBSD)

I've not tested the patch, but it all seems reasonable to me.

This revision is now accepted and ready to land.Jul 9 2022, 12:31 PM

Thanks for the review, will wait a few days for others to possibly shime in.

The most recent version of this looks good. Thank you!

This revision was automatically updated to reflect the committed changes.