testing: provide meaningful error when pytest is not available

[melifaro]

Summary

Provide meaningful error for pytest-based test when pytest is not available on the system.

Unfortunately, atf format does not provide any way of signalling any error message back to the atf runner when listing tests.
Work this around by reporting "test_cases_list_pytest_binary_not_found" test instead.

Test Plan

OLD behaviour:

7:40 [0] m@devel0 s kyua list -k /usr/tests/sys/net/routing/Kyuafile test_rtsock_multipath.py
test_rtsock_multipath.py:__test_cases_list__
7:40 [0] m@devel0 s kyua test -k /usr/tests/sys/net/routing/Kyuafile test_rtsock_multipath.py
test_rtsock_multipath.py:__test_cases_list__  ->  broken: Test program did not exit cleanly  [0.001s]

NEW behaviour:

7:43 [1] m@devel2 s kyua list -k /usr/tests/sys/netinet6/Kyuafile test_ip6_output.py
test_ip6_output.py:__test_cases_list_pytest_binary_not_found__
7:44 [1] m@devel2 s kyua test -k /usr/tests/sys/netinet6/Kyuafile test_ip6_output.py
test_ip6_output.py:__test_cases_list_pytest_binary_not_found__  ->  skipped: Required program 'pytest' not found in PATH  [0.001s]

[kp]

LGTM

libexec/atf/atf-pytest-wrapper/atf_pytest_wrapper.cpp

+// vim: ts=2 sw=2 et
+
 #include <format>
 #include <iostream>
 #include <map>
 #include <string>
 #include <vector>
 #include <stdlib.h>
 #include <unistd.h>
 
void SetEnv() {
 
       // Pass ATF kv pairs as env variables to avoid dealing with
       // pytest parser
       for (auto [k, v]: kv_map) {
         setenv((kAtfVar + k).c_str(), v.c_str(), 1);
       }
     }
 
-    int Run(std::string binary, std::vector<std::string> args) {
+    bool Run(std::string binary, std::vector<std::string> args) {
       if (flag_debug) {
         PrintVector("OUT", args);
       }
       // allocate array with final NULL
       char **arr = new char*[args.size() + 1]();
       for (unsigned long i = 0; i < args.size(); i++) {
         // work around 'char *const *'
         arr[i] = strdup(args[i].c_str());
       }
-      return (execvp(binary.c_str(), arr) != 0);
+      return execvp(binary.c_str(), arr) == 0;
     }
 
+    void ReportError() {
+      if (flag_list) {
+        std::cout << "Content-Type: application/X-atf-tp; version=\"1\"";
+        std::cout << std::endl << std::endl;
+        std::cout << "ident: __test_cases_list_"<< kPytestName << "_binary_" <<
+          "not_found__" << std::endl;
+      } else {
+        std::cout << "execvp(" << kPytestName << ") failed: " <<
+            std::strerror(errno) << std::endl;
+      }
+    }
+
     int Process() {
       SetEnv();
-      return Run(kPytestName, BuildArgs());
+      if (!Run(kPytestName, BuildArgs())) {
+        ReportError();
+      }
+      return 0;
     }
 };
 
 
 int main(int argc, char **argv) {
   Handler handler;
 
   handler.Parse(argc, argv);
   return handler.Process();
 }