crypto: Fix assertions for digest-only sessions with separate output.
ClosedPublic
Actions

Authored by jhb on Jun 23 2022, 5:51 PM.

Details

Reviewers

Commits

rGb53f356918f8: crypto: Fix assertions for digest-only sessions with separate output.
rGc71f2370c5d4: crypto: Fix assertions for digest-only sessions with separate output.

Summary

Digest-only sessions do not generate modified payload as an output, so
don't bother asserting anything about the payload with respect to the
output buffer other than the payload output start being zero.

In addition, a verify request on a digest-only session doesn't
generate any output at all so should never have a separate output
buffer.

PR: 252316
Co-authored-by: Jeremy Faulkner <gldisater@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 23 2022, 5:51 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptJun 23 2022, 5:51 PM

jhb requested review of this revision.Jun 23 2022, 5:51 PM

Harbormaster completed remote builds in B46096: Diff 107302.Jun 23 2022, 5:51 PM

markj accepted this revision.Jun 23 2022, 6:55 PM

This revision is now accepted and ready to land.Jun 23 2022, 6:55 PM

gldisater_gmail.com added a subscriber: gldisater_gmail.com.Jun 23 2022, 11:42 PM

Closed by commit rGc71f2370c5d4: crypto: Fix assertions for digest-only sessions with separate output. (authored by jhb). · Explain WhyJun 30 2022, 5:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc71f2370c5d4: crypto: Fix assertions for digest-only sessions with separate output..

jhb added a commit: rGb53f356918f8: crypto: Fix assertions for digest-only sessions with separate output..Jul 13 2022, 4:48 PM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

crypto.c

5 lines

Diff 107615

View Options

crypto: Fix assertions for digest-only sessions with separate output.ClosedPublicActions