Page MenuHomeFreeBSD

truss: Make control message header parsing more robust
ClosedPublic

Authored by markj on Jun 13 2022, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 3, 4:14 PM
Unknown Object (File)
Mon, Apr 27, 12:15 PM
Unknown Object (File)
Mon, Apr 27, 6:06 AM
Unknown Object (File)
Fri, Apr 24, 12:08 AM
Unknown Object (File)
Thu, Apr 23, 2:10 AM
Unknown Object (File)
Tue, Apr 21, 8:46 PM
Unknown Object (File)
Tue, Apr 21, 8:36 PM
Unknown Object (File)
Tue, Apr 21, 8:21 AM
Subscribers

Details

Summary

print_cmsg() was assuming that the control message chain is well-formed,
but that isn't necessarily the case for sendmsg(2). In particular, if
cmsg_len is zero, print_cmsg() will loop forever. Check for truncated
headers and try to recover if possible.

Test Plan

This was found by running a syzkaller reproducer under truss. Now it prints:

94908: sendmsg(3,{NULL,0,0x0,0,{{level=SOL_SOCKET,type=SCM_RIGHTS,data={}}{<invalid cmsg len=0>}},108,0},0) ERR#22 'Invalid argument'

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable