Page MenuHomeFreeBSD

Drop redundant case from RB_NEXT, RB_PREV
ClosedPublic

Authored by dougm on Jun 10 2022, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 11, 1:20 PM
Unknown Object (File)
Thu, Apr 3, 2:55 PM
Unknown Object (File)
Mar 18 2025, 2:33 AM
Unknown Object (File)
Mar 14 2025, 7:37 AM
Unknown Object (File)
Feb 20 2025, 8:52 PM
Unknown Object (File)
Feb 20 2025, 8:27 PM
Unknown Object (File)
Feb 11 2025, 9:02 AM
Unknown Object (File)
Feb 11 2025, 7:47 AM
Subscribers

Details

Summary

In RB_NEXT, when there is no RB_RIGHT node, the search must proceed through the parent node.

There is code written to handle the case when the parent is non-NULL and the current element is the left child of that parent. If you assume that the current element is either the left child of its parent, or the right child of its parent, but not both, then this test is not necessary. Instead of assigning RB_PARENT(elm, field) to elm when elm == RB_LEFT, removing the test has the code assign RB_PARENT(elm, field) to elm when elm != RB_RIGHT. There's no need to examine the RB_LEFT field at all.

This change removes that needless RB_LEFT test, and makes a similar change to the RB_PREV implementation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable