- Fix build on i386

[farrokhi]

Summary

• Fix build on i386 as suggested by Pavel Odintsov <[e-mail]>

[mat]

I'm not sure I understand what it does.
Does this mean it needs at least an i586 to build ?

[farrokhi]

In D3543#72764, @mat wrote:

I'm not sure I understand what it does.
Does this mean it needs at least an i586 to build ?

Yes. It builds on i586 and above.

[mat]

Because, as I read this, it's about like "if we're an i386, and it's not an i586, do as if we're an i586 anyway."

In that case, adding:

CFLAGS_i386= -march=i586

will do the same, and you don't need bsd.port.pre.mk.

[farrokhi]

Do I need a += instead of = ?

[mat]

In D3543#72770, @farrokhi wrote:

Do I need a += instead of = ?

If CFLAGS_i386 is already defined earlier, just append to it. If it is not, then no.

[farrokhi]

• Improved version of previous patch

[mat]

In the commit message, you may add a note about it not working if <i586, explaining a bit why the change is needed :-)